Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2863023002: Get rid of ExtensionServiceTestBase::ResetThreadBundle (Closed)

Created:
3 years, 7 months ago by Marijn Kruisselbrink
Modified:
3 years, 7 months ago
Reviewers:
Devlin
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org, gab
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Get rid of ExtensionServiceTestBase::ResetThreadBundle The method is fundamentally flawed (it invalidates the TaskRunners for anything that might have already be initialized), and also isn't actually used other than in one particular test that doesn't seem to need what it does anyway. BUG=None Review-Url: https://codereview.chromium.org/2863023002 Cr-Commit-Position: refs/heads/master@{#469563} Committed: https://chromium.googlesource.com/chromium/src/+/82cbc419c9725b0d7dddb403bce2f367638dfb35

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -19 lines) Patch
M chrome/browser/extensions/api/developer_private/extension_info_generator_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_service_test_base.h View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/extensions/extension_service_test_base.cc View 3 chunks +0 lines, -12 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Marijn Kruisselbrink
3 years, 7 months ago (2017-05-04 23:48:37 UTC) #4
Devlin
LGTM. if everything still works without this, I'm happy to have it gone! Next step ...
3 years, 7 months ago (2017-05-05 01:12:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2863023002/1
3 years, 7 months ago (2017-05-05 01:14:03 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-05 01:19:55 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/82cbc419c9725b0d7dddb403bce2...

Powered by Google App Engine
This is Rietveld 408576698