Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(840)

Issue 2862993002: VR: Don't stay in VR when exiting webVR if the activity doesn't support VR browsing. (Closed)

Created:
3 years, 7 months ago by mthiesse
Modified:
3 years, 7 months ago
Reviewers:
ymalik, cjgrant
CC:
chromium-reviews, feature-vr-reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

VR: Don't stay in VR when exiting webVR if the activity doesn't support VR browsing. BUG=718610 Review-Url: https://codereview.chromium.org/2862993002 Cr-Commit-Position: refs/heads/master@{#469525} Committed: https://chromium.googlesource.com/chromium/src/+/f05a24a46d1c6b00e76ccdf23f8fae3c39b0aab6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
mthiesse
PTAL You're my replacement bshe's while he's on pat leave :)
3 years, 7 months ago (2017-05-04 21:55:16 UTC) #3
ymalik
lgtm
3 years, 7 months ago (2017-05-04 22:39:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2862993002/1
3 years, 7 months ago (2017-05-04 22:42:00 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2017-05-04 23:46:39 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f05a24a46d1c6b00e76ccdf23f8f...

Powered by Google App Engine
This is Rietveld 408576698