Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2862963002: MD Settings/Help: re-arrange separator DOM on about page (Closed)

Created:
3 years, 7 months ago by Dan Beam
Modified:
3 years, 7 months ago
Reviewers:
dschuyler
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings/Help: re-arrange separator DOM on about page R=dschuyler@chromium.org BUG=718345 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2862963002 Cr-Commit-Position: refs/heads/master@{#469494} Committed: https://chromium.googlesource.com/chromium/src/+/99f1e6d53a28086375ee80a5907fbc260da0d8da

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/settings/about_page/about_page.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
Dan Beam
3 years, 7 months ago (2017-05-04 21:02:56 UTC) #2
dschuyler
lgtm
3 years, 7 months ago (2017-05-04 22:33:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2862963002/1
3 years, 7 months ago (2017-05-04 22:39:35 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-04 22:46:36 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/99f1e6d53a28086375ee80a5907f...

Powered by Google App Engine
This is Rietveld 408576698