Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4515)

Unified Diff: chrome/browser/ui/views/payments/payment_request_sheet_controller.h

Issue 2862913002: [Web Payments] Let subsheets define the initial focus (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/payments/payment_request_sheet_controller.h
diff --git a/chrome/browser/ui/views/payments/payment_request_sheet_controller.h b/chrome/browser/ui/views/payments/payment_request_sheet_controller.h
index 3a3eacba56a3030b75d09005e3a36f5cbd427e66..a97760869858ef3ced2764b56519d6d42a3eacbe 100644
--- a/chrome/browser/ui/views/payments/payment_request_sheet_controller.h
+++ b/chrome/browser/ui/views/payments/payment_request_sheet_controller.h
@@ -33,6 +33,21 @@ class PaymentRequestSheetController : public views::ButtonListener {
PaymentRequestDialogView* dialog);
~PaymentRequestSheetController() override;
+ // Creates a view to be displayed in the PaymentRequestDialog. The header view
+ // is the view displayed on top of the dialog, containing title, (optional)
Mathieu 2017/05/04 19:32:34 nit: extra leading space
anthonyvd 2017/05/04 20:56:59 Done.
+ // back button, and close buttons.
+ // The content view is displayed between the header view and the pay/cancel
+ // buttons. Also adds the footer, returned by CreateFooterView(), which is
+ // clamped to the bottom of the containing view. The returned view takes
+ // ownership of the header, the content, and the footer.
+ // +---------------------------+
+ // | HEADER VIEW |
+ // +---------------------------+
+ // | CONTENT |
+ // | VIEW |
+ // +---------------------------+
+ // | EXTRA VIEW | PAY | CANCEL | <-- footer
+ // +---------------------------+
std::unique_ptr<views::View> CreateView();
PaymentRequestSpec* spec() { return spec_; }
@@ -101,23 +116,6 @@ class PaymentRequestSheetController : public views::ButtonListener {
virtual views::View* GetFirstFocusedView();
private:
- // Creates a view to be displayed in the PaymentRequestDialog.
- // |header_view| is the view displayed on top of the dialog, containing title,
- // (optional) back button, and close buttons.
- // |content_view| is displayed between |header_view| and the pay/cancel
- // buttons. Also adds the footer, returned by CreateFooterView(), which is
- // clamped to the bottom of the containing view. The returned view takes
- // ownership of |header_view|, |content_view|, and the footer.
- // +---------------------------+
- // | HEADER VIEW |
- // +---------------------------+
- // | CONTENT |
- // | VIEW |
- // +---------------------------+
- // | EXTRA VIEW | PAY | CANCEL | <-- footer
- // +---------------------------+
- std::unique_ptr<views::View> CreatePaymentView();
-
// All these are not owned. Will outlive this.
PaymentRequestSpec* spec_;
PaymentRequestState* state_;

Powered by Google App Engine
This is Rietveld 408576698