Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6061)

Unified Diff: chrome/browser/ui/views/payments/payment_request_sheet_controller.cc

Issue 2862913002: [Web Payments] Let subsheets define the initial focus (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/payments/payment_request_sheet_controller.cc
diff --git a/chrome/browser/ui/views/payments/payment_request_sheet_controller.cc b/chrome/browser/ui/views/payments/payment_request_sheet_controller.cc
index de6934cf3e1cf43edb88e29da3c840a81bf8f68c..bf85a4f18ef3c30f28670578a2f32b6857ee484a 100644
--- a/chrome/browser/ui/views/payments/payment_request_sheet_controller.cc
+++ b/chrome/browser/ui/views/payments/payment_request_sheet_controller.cc
@@ -86,59 +86,6 @@ PaymentRequestSheetController::PaymentRequestSheetController(
PaymentRequestSheetController::~PaymentRequestSheetController() {}
std::unique_ptr<views::View> PaymentRequestSheetController::CreateView() {
- std::unique_ptr<views::View> view = CreatePaymentView();
- UpdateContentView();
- return view;
-}
-
-void PaymentRequestSheetController::UpdateContentView() {
- content_view_->RemoveAllChildViews(true);
- FillContentView(content_view_);
- content_view_->Layout();
- pane_->SizeToPreferredSize();
- // Now that the content and its surrounding pane are updated, force a Layout
- // on the ScrollView so that it updates its scroll bars now.
- scroll_->Layout();
-}
-
-std::unique_ptr<views::Button>
-PaymentRequestSheetController::CreatePrimaryButton() {
- return nullptr;
-}
-
-base::string16 PaymentRequestSheetController::GetSecondaryButtonLabel() {
- return l10n_util::GetStringUTF16(IDS_CANCEL);
-}
-
-bool PaymentRequestSheetController::ShouldShowHeaderBackArrow() {
- return true;
-}
-
-std::unique_ptr<views::View>
-PaymentRequestSheetController::CreateExtraFooterView() {
- return nullptr;
-}
-
-void PaymentRequestSheetController::ButtonPressed(
- views::Button* sender, const ui::Event& event) {
- switch (static_cast<PaymentRequestCommonTags>(sender->tag())) {
- case PaymentRequestCommonTags::CLOSE_BUTTON_TAG:
- dialog()->CloseDialog();
- break;
- case PaymentRequestCommonTags::BACK_BUTTON_TAG:
- dialog()->GoBack();
- break;
- case PaymentRequestCommonTags::PAY_BUTTON_TAG:
- dialog()->Pay();
- break;
- case PaymentRequestCommonTags::PAYMENT_REQUEST_COMMON_TAG_MAX:
- NOTREACHED();
- break;
- }
-}
-
-std::unique_ptr<views::View>
-PaymentRequestSheetController::CreatePaymentView() {
std::unique_ptr<SheetView> view = base::MakeUnique<SheetView>();
view->set_background(views::Background::CreateSolidBackground(SK_ColorWHITE));
@@ -188,11 +135,58 @@ PaymentRequestSheetController::CreatePaymentView() {
layout->StartRow(0, 0);
layout->AddView(CreateFooterView().release());
- view->SetFirstFocusableView(GetFirstFocusedView());
+ UpdateContentView();
+ view->SetFirstFocusableView(GetFirstFocusedView());
return std::move(view);
}
+void PaymentRequestSheetController::UpdateContentView() {
+ content_view_->RemoveAllChildViews(true);
+ FillContentView(content_view_);
+ content_view_->Layout();
+ pane_->SizeToPreferredSize();
+ // Now that the content and its surrounding pane are updated, force a Layout
+ // on the ScrollView so that it updates its scroll bars now.
+ scroll_->Layout();
+}
+
+std::unique_ptr<views::Button>
+PaymentRequestSheetController::CreatePrimaryButton() {
+ return nullptr;
+}
+
+base::string16 PaymentRequestSheetController::GetSecondaryButtonLabel() {
+ return l10n_util::GetStringUTF16(IDS_CANCEL);
+}
+
+bool PaymentRequestSheetController::ShouldShowHeaderBackArrow() {
+ return true;
+}
+
+std::unique_ptr<views::View>
+PaymentRequestSheetController::CreateExtraFooterView() {
+ return nullptr;
+}
+
+void PaymentRequestSheetController::ButtonPressed(views::Button* sender,
+ const ui::Event& event) {
+ switch (static_cast<PaymentRequestCommonTags>(sender->tag())) {
+ case PaymentRequestCommonTags::CLOSE_BUTTON_TAG:
+ dialog()->CloseDialog();
+ break;
+ case PaymentRequestCommonTags::BACK_BUTTON_TAG:
+ dialog()->GoBack();
+ break;
+ case PaymentRequestCommonTags::PAY_BUTTON_TAG:
+ dialog()->Pay();
+ break;
+ case PaymentRequestCommonTags::PAYMENT_REQUEST_COMMON_TAG_MAX:
+ NOTREACHED();
+ break;
+ }
+}
+
std::unique_ptr<views::View> PaymentRequestSheetController::CreateFooterView() {
std::unique_ptr<views::View> container = base::MakeUnique<views::View>();

Powered by Google App Engine
This is Rietveld 408576698