[Web Payments] Let subsheets define the initial focus

[Web Payments] Let subsheets define the initial focus

BUG=717322
Review-Url: https://codereview.chromium.org/2862913002
Cr-Commit-Position: refs/heads/master@{#469490}
Committed: https://chromium.googlesource.com/chromium/src/+/5be7c3c145790e7c762f8ab371d3ea5d2673b337

[anthonyvd, 2017-05-04 19:01:11]

Description was changed from

==========
[Web Payments] Let subsheets define the initial focus

BUG=
==========

to

==========
[Web Payments] Let subsheets define the initial focus

BUG=717322
==========

[anthonyvd, 2017-05-04 19:01:34]

The CQ bit was checked by anthonyvd@chromium.org to run a CQ dry run

[anthonyvd, 2017-05-04 19:01:55]

anthonyvd@chromium.org changed reviewers:
+ mathp@chromium.org

[anthonyvd, 2017-05-04 19:01:56]

Hi Math, PTAL!

[commit-bot: I haz the power, 2017-05-04 19:03:10]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Mathieu, 2017-05-04 19:32:34]

lgtm

https://codereview.chromium.org/2862913002/diff/1/chrome/browser/ui/views/pay...
File chrome/browser/ui/views/payments/editor_view_controller.cc (right):

https://codereview.chromium.org/2862913002/diff/1/chrome/browser/ui/views/pay...
chrome/browser/ui/views/payments/editor_view_controller.cc:225: if
(!first_field_view_)
TODO(crbug.com/xxxxxx): Should be the first view that's incomplete/empty.

https://codereview.chromium.org/2862913002/diff/1/chrome/browser/ui/views/pay...
File chrome/browser/ui/views/payments/payment_request_sheet_controller.h
(right):

https://codereview.chromium.org/2862913002/diff/1/chrome/browser/ui/views/pay...
chrome/browser/ui/views/payments/payment_request_sheet_controller.h:37: //  is
the view displayed on top of the dialog, containing title, (optional)
nit: extra leading space

[commit-bot: I haz the power, 2017-05-04 19:52:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-04 19:52:54]

Dry run: This issue passed the CQ dry run.

[anthonyvd, 2017-05-04 20:56:55]

The CQ bit was checked by anthonyvd@chromium.org

[anthonyvd, 2017-05-04 20:56:56]

The patchset sent to the CQ was uploaded after l-g-t-m from mathp@chromium.org
Link to the patchset: https://codereview.chromium.org/2862913002/#ps20001
(title: "Address comments.")

[anthonyvd, 2017-05-04 20:56:59]

https://codereview.chromium.org/2862913002/diff/1/chrome/browser/ui/views/pay...
File chrome/browser/ui/views/payments/editor_view_controller.cc (right):

https://codereview.chromium.org/2862913002/diff/1/chrome/browser/ui/views/pay...
chrome/browser/ui/views/payments/editor_view_controller.cc:225: if
(!first_field_view_)
On 2017/05/04 at 19:32:34, Mathieu wrote:
> TODO(crbug.com/xxxxxx): Should be the first view that's incomplete/empty.

Done.

https://codereview.chromium.org/2862913002/diff/1/chrome/browser/ui/views/pay...
File chrome/browser/ui/views/payments/payment_request_sheet_controller.h
(right):

https://codereview.chromium.org/2862913002/diff/1/chrome/browser/ui/views/pay...
chrome/browser/ui/views/payments/payment_request_sheet_controller.h:37: //  is
the view displayed on top of the dialog, containing title, (optional)
On 2017/05/04 at 19:32:34, Mathieu wrote:
> nit: extra leading space

Done.

[commit-bot: I haz the power, 2017-05-04 20:57:20]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-04 21:03:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-04 21:03:16]

Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[anthonyvd, 2017-05-04 21:28:40]

The CQ bit was checked by anthonyvd@chromium.org

[anthonyvd, 2017-05-04 21:28:40]

The patchset sent to the CQ was uploaded after l-g-t-m from mathp@chromium.org
Link to the patchset: https://codereview.chromium.org/2862913002/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2017-05-04 21:29:07]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-04 22:19:22]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1493933320246000,
"parent_rev": "8bef0bcb6a3190e14abced2eefb51f37cae90abc", "commit_rev":
"5be7c3c145790e7c762f8ab371d3ea5d2673b337"}

[commit-bot: I haz the power, 2017-05-04 22:19:33]

Description was changed from

==========
[Web Payments] Let subsheets define the initial focus

BUG=717322
==========

to

==========
[Web Payments] Let subsheets define the initial focus

BUG=717322

Review-Url: https://codereview.chromium.org/2862913002
Cr-Commit-Position: refs/heads/master@{#469490}
Committed:
https://chromium.googlesource.com/chromium/src/+/5be7c3c145790e7c762f8ab371d3...
==========

[commit-bot: I haz the power, 2017-05-04 22:19:34]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/5be7c3c145790e7c762f8ab371d3...