Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2862903002:
[Mac] Reverse bookmark bar overflow chevron in RTL (Closed)
|
Created:
3 years, 7 months ago by lgrey Modified:
3 years, 7 months ago Reviewers:
Elly Fong-Jones CC:
chromium-reviews, tfarina, mac-reviews_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
Description[Mac] Reverse bookmark bar overflow chevron in RTL
BUG=648560
Review-Url: https://codereview.chromium.org/2862903002
Cr-Commit-Position: refs/heads/master@{#470046}
Committed: https://chromium.googlesource.com/chromium/src/+/c4a9fa7f810710c0872eb72826916bf9c060063a
Patch Set 1 #
Messages
Total messages: 20 (12 generated)
The CQ bit was checked by lgrey@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgrey@chromium.org changed reviewers: + ellyjones@chromium.org
PTAL :)
lgtm
The CQ bit was checked by lgrey@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
The CQ bit was checked by lgrey@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
The CQ bit was checked by lgrey@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1494265544138210, "parent_rev":
"4b94565eebdcb13ab162c2e5c40d0e4409b9446c", "commit_rev":
"c4a9fa7f810710c0872eb72826916bf9c060063a"}
Message was sent while issue was closed.
Description was changed from ========== [Mac] Reverse bookmark bar overflow chevron in RTL BUG=648560 ========== to ========== [Mac] Reverse bookmark bar overflow chevron in RTL BUG=648560 Review-Url: https://codereview.chromium.org/2862903002 Cr-Commit-Position: refs/heads/master@{#470046} Committed: https://chromium.googlesource.com/chromium/src/+/c4a9fa7f810710c0872eb7282691... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/c4a9fa7f810710c0872eb7282691... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
