Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Issue 2862873002: base: add a unit test for SetCloseOnExec() function (Closed)

Created:
3 years, 7 months ago by tfarina
Modified:
3 years, 7 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, danakj+watch_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

base: add a unit test for SetCloseOnExec() function BUG=None TEST=base_unittests --gtest_filter=FileUtilTest.SetCloseOnExec R=thestig@chromium.org Review-Url: https://codereview.chromium.org/2862873002 Cr-Commit-Position: refs/heads/master@{#469422} Committed: https://chromium.googlesource.com/chromium/src/+/ab528fac3e3595e8e3f90e10b4f33e2d563ed238

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M base/files/file_util_unittest.cc View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
tfarina
3 years, 7 months ago (2017-05-04 16:42:20 UTC) #3
Lei Zhang
lgtm
3 years, 7 months ago (2017-05-04 19:21:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2862873002/1
3 years, 7 months ago (2017-05-04 19:22:18 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-05-04 19:27:22 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ab528fac3e3595e8e3f90e10b4f3...

Powered by Google App Engine
This is Rietveld 408576698