Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 2862863002: Remove fullscreen requirement from listening for vrdisplayactivate inside a frame. (Closed)

Created:
3 years, 7 months ago by mthiesse
Modified:
3 years, 7 months ago
Reviewers:
bajones
CC:
chromium-reviews, haraken, blink-reviews, feature-vr-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove fullscreen requirement from listening for vrdisplayactivate inside a frame. BUG=718445 Review-Url: https://codereview.chromium.org/2862863002 Cr-Commit-Position: refs/heads/master@{#469399} Committed: https://chromium.googlesource.com/chromium/src/+/8847dabd9aef1075e157dced4d511a77308dedc2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -7 lines) Patch
M third_party/WebKit/Source/modules/vr/NavigatorVR.cpp View 1 chunk +1 line, -7 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
mthiesse
PTAL
3 years, 7 months ago (2017-05-04 15:05:38 UTC) #2
bajones
lgtm
3 years, 7 months ago (2017-05-04 16:29:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2862863002/1
3 years, 7 months ago (2017-05-04 16:46:37 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clang_dbg_recipe/builds/261759)
3 years, 7 months ago (2017-05-04 18:06:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2862863002/1
3 years, 7 months ago (2017-05-04 18:10:39 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-04 18:47:50 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8847dabd9aef1075e157dced4d51...

Powered by Google App Engine
This is Rietveld 408576698