Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 2862823002: Introducing audio output device authorization timeout for Linux. (Closed)

Created:
3 years, 7 months ago by o1ka
Modified:
3 years, 7 months ago
Reviewers:
Guido Urdaneta
CC:
chromium-reviews, posciak+watch_chromium.org, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org, feature-media-reviews_chromium.org, DaleCurtis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Introducing audio output device authorization timeout for Linux. The outcome is: if device authorization for a renderer is taking too long it will be interupted. Page load will continue normally, some of the audio playback on it may not work. BUG=647498 Review-Url: https://codereview.chromium.org/2862823002 Cr-Commit-Position: refs/heads/master@{#469308} Committed: https://chromium.googlesource.com/chromium/src/+/7d472f296e715c26fa1dbe8295b607421319c53f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M content/renderer/media/audio_device_factory.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
o1ka
Guido - PTAL
3 years, 7 months ago (2017-05-04 10:12:41 UTC) #4
Guido Urdaneta
lgtm
3 years, 7 months ago (2017-05-04 10:45:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2862823002/1
3 years, 7 months ago (2017-05-04 11:06:04 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-04 11:10:49 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7d472f296e715c26fa1dbe8295b6...

Powered by Google App Engine
This is Rietveld 408576698