[iOS Clean] Wired up ContextMenuCommands.

ios/clean/chrome/browser/ui/commands/context_menu_commands.h

Index: ios/clean/chrome/browser/ui/commands/context_menu_commands.h
diff --git a/ios/clean/chrome/browser/ui/commands/context_menu_commands.h b/ios/clean/chrome/browser/ui/commands/context_menu_commands.h
new file mode 100644
index 0000000000000000000000000000000000000000..a977d3d7bdbe807e8f9e1c4ac3c45085cccced8f
--- /dev/null
+++ b/ios/clean/chrome/browser/ui/commands/context_menu_commands.h
@@ -0,0 +1,30 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef IOS_CLEAN_CHROME_BROWSER_UI_COMMANDS_CONTEXT_MENU_COMMANDS_H_
+#define IOS_CLEAN_CHROME_BROWSER_UI_COMMANDS_CONTEXT_MENU_COMMANDS_H_
+
+class GURL;
+
+// Command protocol for commands relating to the context menu.
+@protocol ContextMenuCommands
+// Executes the JavaScript in |URL|'s content.
+- (void)openJavaScriptURL:(const GURL*)URL;
+// Opens |URL| in a new tab.
+- (void)openURLInNewTab:(const GURL*)URL;

[kkhorimoto, 2017/05/04 05:38:01]

Do we currently have any mechanism besides DCHECKs in CommandDispatcher to help
avoid naming collisions for commands?  I'm thinking it might be useful to make
more verbose naming here that mention that it's specific to context menu
actions.

[marq (ping after 24h), 2017/05/04 09:41:28]

My thinking was that commands would be grouped by function, not source. There
should only need to be one 'openURLInNewTab' command; there may be several
places where that command is called from.

The tools menu, which by definition throws together a bunch of unrelated
functions, seems like its dispatcher will have to conform to a bucketload of
protocols.

[kkhorimoto, 2017/05/05 05:17:54]

Makes sense.  There's still the issue of commands that need to be chained (i.e.
a LoadURL command coupled with a call to WebContextMenuCoordinator's |-stop|). 
My current implementation uses blocks to chain these commands together, as it
seems better than creating ContextMenu-specific versions of these commands that
call through to other dispatcher targets.

+// Opens |URL| in a new Incognito tab.
+- (void)openURLInNewIncognitoTab:(const GURL*)URL;
+// Adds |URL| to the Reading List.
+- (void)copyURL:(const GURL*)URL;
+// Saves's the image at |imageURL| to the camera roll.
+- (void)saveImageAtURL:(const GURL*)imageURL;
+// Opens the image at |imageURL|.
+- (void)openImageAtURL:(const GURL*)imageURL;
+// Opens the image at |imageURL| in a new tab.
+- (void)openImageAtURLInNewTab:(const GURL*)imageURL;
+// Stops the context menu UI with no navigation action.
+- (void)cancelContextMenu;
+@end
+
+#endif  // IOS_CLEAN_CHROME_BROWSER_UI_COMMANDS_CONTEXT_MENU_COMMANDS_H_