ios/clean/chrome/browser/ui/commands/context_menu_commands.h - Issue 2862783002: [iOS Clean] Wired up ContextMenuCommands.

Side by Side Diff: ios/clean/chrome/browser/ui/commands/context_menu_commands.h

Issue 2862783002: [iOS Clean] Wired up ContextMenuCommands. (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« no previous file with comments | « ios/clean/chrome/browser/ui/commands/BUILD.gn ('k') | ios/clean/chrome/browser/ui/context_menu/context_menu_mediator.h » ('j') | ios/clean/chrome/browser/ui/context_menu/context_menu_mediator.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef IOS_CLEAN_CHROME_BROWSER_UI_COMMANDS_CONTEXT_MENU_COMMANDS_H_

	6 #define IOS_CLEAN_CHROME_BROWSER_UI_COMMANDS_CONTEXT_MENU_COMMANDS_H_

	7

	8 class GURL;

	9

	10 // Command protocol for commands relating to the context menu.

	11 @protocol ContextMenuCommands

	12 // Executes the JavaScript in \|URL\|'s content.

	13 - (void)openJavaScriptURL:(const GURL*)URL;

	14 // Opens \|URL\| in a new tab.

	15 - (void)openURLInNewTab:(const GURL*)URL;
	kkhorimoto 2017/05/04 05:38:01 Do we currently have any mechanism besides DCHECKs Do we currently have any mechanism besides DCHECKs in CommandDispatcher to help avoid naming collisions for commands? I'm thinking it might be useful to make more verbose naming here that mention that it's specific to context menu actions. marq (ping after 24h) 2017/05/04 09:41:28 My thinking was that commands would be grouped by Show quoted text On 2017/05/04 05:38:01, kkhorimoto_ wrote: > Do we currently have any mechanism besides DCHECKs in CommandDispatcher to help > avoid naming collisions for commands? I'm thinking it might be useful to make > more verbose naming here that mention that it's specific to context menu > actions. My thinking was that commands would be grouped by function, not source. There should only need to be one 'openURLInNewTab' command; there may be several places where that command is called from. The tools menu, which by definition throws together a bunch of unrelated functions, seems like its dispatcher will have to conform to a bucketload of protocols. kkhorimoto 2017/05/05 05:17:54 Makes sense. There's still the issue of commands Show quoted text On 2017/05/04 09:41:28, marq (OOO to May 9) wrote: > On 2017/05/04 05:38:01, kkhorimoto_ wrote: > > Do we currently have any mechanism besides DCHECKs in CommandDispatcher to > help > > avoid naming collisions for commands? I'm thinking it might be useful to make > > more verbose naming here that mention that it's specific to context menu > > actions. > > My thinking was that commands would be grouped by function, not source. There > should only need to be one 'openURLInNewTab' command; there may be several > places where that command is called from. > > The tools menu, which by definition throws together a bunch of unrelated > functions, seems like its dispatcher will have to conform to a bucketload of > protocols. Makes sense. There's still the issue of commands that need to be chained (i.e. a LoadURL command coupled with a call to WebContextMenuCoordinator's \|-stop\|). My current implementation uses blocks to chain these commands together, as it seems better than creating ContextMenu-specific versions of these commands that call through to other dispatcher targets.
	16 // Opens \|URL\| in a new Incognito tab.

	17 - (void)openURLInNewIncognitoTab:(const GURL*)URL;

	18 // Adds \|URL\| to the Reading List.

	19 - (void)copyURL:(const GURL*)URL;

	20 // Saves's the image at \|imageURL\| to the camera roll.

	21 - (void)saveImageAtURL:(const GURL*)imageURL;

	22 // Opens the image at \|imageURL\|.

	23 - (void)openImageAtURL:(const GURL*)imageURL;

	24 // Opens the image at \|imageURL\| in a new tab.

	25 - (void)openImageAtURLInNewTab:(const GURL*)imageURL;

	26 // Stops the context menu UI with no navigation action.

	27 - (void)cancelContextMenu;

	28 @end

	29

	30 #endif // IOS_CLEAN_CHROME_BROWSER_UI_COMMANDS_CONTEXT_MENU_COMMANDS_H_

OLD	NEW