Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 2862763002: [wasm] Avoid js-typed-lowering optimization for wasm Memory objects (Closed)

Created:
3 years, 7 months ago by gdeepti
Modified:
3 years, 7 months ago
CC:
v8-reviews_googlegroups.com, wasm-v8_google.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Avoid js-typed-lowering optimization for wasm Memory objects If an ArrayBuffer is setup through the WebAssembly.Memory constructor, identify these with a flag and avoid optimizations in js-typed-lowering.cc. This is needed becasue buffers associated with memory objects can be grown/detached leading to crashes. BUG=chromium:717194 Review-Url: https://codereview.chromium.org/2862763002 Cr-Commit-Position: refs/heads/master@{#45105} Committed: https://chromium.googlesource.com/v8/v8/+/82503e9ba30f38d428431f69a82f885569ac4913

Patch Set 1 #

Patch Set 2 : Add test #

Patch Set 3 : Cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -2 lines) Patch
M src/compiler/js-typed-lowering.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M src/objects.h View 1 2 2 chunks +6 lines, -0 lines 0 comments Download
M src/objects-inl.h View 1 chunk +8 lines, -0 lines 0 comments Download
M src/wasm/wasm-module.cc View 2 chunks +2 lines, -0 lines 0 comments Download
A test/mjsunit/regress/wasm/regression-717194.js View 1 2 1 chunk +30 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (13 generated)
gdeepti
3 years, 7 months ago (2017-05-04 05:26:40 UTC) #9
Benedikt Meurer
Thanks. LGTM!
3 years, 7 months ago (2017-05-04 05:38:01 UTC) #10
bradnelson
lgtm
3 years, 7 months ago (2017-05-04 17:20:19 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2862763002/40001
3 years, 7 months ago (2017-05-04 17:20:25 UTC) #15
commit-bot: I haz the power
3 years, 7 months ago (2017-05-04 17:22:04 UTC) #18
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/82503e9ba30f38d428431f69a82f885569a...

Powered by Google App Engine
This is Rietveld 408576698