Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2862753002: Mark Render{Frame,View}::GetWebkitPreferences() return values as const. (Closed)

Created:
3 years, 7 months ago by Lei Zhang
Modified:
3 years, 7 months ago
Reviewers:
piman
CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, darin-cc_chromium.org, creis+watch_chromium.org, mlamouri+watch-content_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Mark Render{Frame,View}::GetWebkitPreferences() return values as const. Also remove some references to NPAPI. Review-Url: https://codereview.chromium.org/2862753002 Cr-Commit-Position: refs/heads/master@{#469844} Committed: https://chromium.googlesource.com/chromium/src/+/8a8fdfd37ff6e1ad0ec56640a956206924c02bef

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -11 lines) Patch
M content/public/common/webplugininfo.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/renderer/render_frame.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/public/renderer/render_view.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_frame_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_view_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_view_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/sad_plugin.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (10 generated)
Lei Zhang
3 years, 7 months ago (2017-05-04 00:49:15 UTC) #6
piman
LGTM, thanks!
3 years, 7 months ago (2017-05-05 19:34:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2862753002/1
3 years, 7 months ago (2017-05-05 19:48:24 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/286905)
3 years, 7 months ago (2017-05-06 00:05:56 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2862753002/1
3 years, 7 months ago (2017-05-06 00:27:21 UTC) #13
commit-bot: I haz the power
3 years, 7 months ago (2017-05-06 18:47:22 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8a8fdfd37ff6e1ad0ec56640a956...

Powered by Google App Engine
This is Rietveld 408576698