Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(532)

Issue 2862673002: Use constexpr TaskTraits constructor in ui. (Closed)

Created:
3 years, 7 months ago by fdoray
Modified:
3 years, 7 months ago
Reviewers:
rjkroege, gab, yoshiki
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, ozone-reviews_chromium.org, yusukes+watch_chromium.org, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, victorhsieh+watch_chromium.org, piman+watch_chromium.org, kalyank
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use constexpr TaskTraits constructor in ui. Use a constexpr constructor that accepts traits in any order instead of the builder pattern to construct TaskTraits in ui. BUG=713683 R=gab@chromium.org TBR=rjkroege@chromium.org, yoshiki@chromium.org Review-Url: https://codereview.chromium.org/2862673002 Cr-Commit-Position: refs/heads/master@{#469151} Committed: https://chromium.googlesource.com/chromium/src/+/d80f4966df8a0f6ff18264e5f6bce9e093aa61a8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -27 lines) Patch
M ui/arc/notification/arc_notification_item.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ui/events/ozone/device/device_manager_manual.cc View 1 chunk +1 line, -4 lines 0 comments Download
M ui/events/ozone/evdev/libgestures_glue/gesture_feedback.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M ui/ozone/platform/drm/gpu/gbm_surfaceless.cc View 1 chunk +1 line, -4 lines 0 comments Download
M ui/ozone/platform/drm/host/drm_display_host_manager.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M ui/ozone/platform/headless/headless_surface_factory.cc View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
fdoray
3 years, 7 months ago (2017-05-03 20:26:11 UTC) #1
fdoray
gab@: PTAL The change will then be TBRed to the owner.
3 years, 7 months ago (2017-05-03 20:26:13 UTC) #3
gab
lgtm
3 years, 7 months ago (2017-05-03 21:12:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2862673002/1
3 years, 7 months ago (2017-05-03 21:53:28 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-03 22:00:31 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d80f4966df8a0f6ff18264e5f6bc...

Powered by Google App Engine
This is Rietveld 408576698