Issue 286263002: [DevTools] Notify embedder about pausing/resuming in debugger.

Issue 286263002: [DevTools] Notify embedder about pausing/resuming in debugger. (Closed)

Created:
6 years, 7 months ago by dgozman

Modified:
6 years, 7 months ago

Reviewers:
pfeldman, yurys

CC:
blink-reviews, jamesr, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, abarth-chromium, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

[DevTools] Notify embedder about pausing/resuming in debugger. BUG=374183 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174389

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fixed comments #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -0 lines)			Patch
M	Source/web/WebDevToolsAgentImpl.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	Source/web/WebDevToolsAgentImpl.cpp	View	1	2 chunks	+3 lines, -0 lines	0 comments	Download
M	public/web/WebDevToolsAgentClient.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

dgozman

Could you please take a look? Main part is https://codereview.chromium.org/288393004.

6 years, 7 months ago (2014-05-16 13:59:39 UTC) #1

pfeldman

lgtm https://codereview.chromium.org/286263002/diff/1/Source/web/WebDevToolsAgentImpl.cpp File Source/web/WebDevToolsAgentImpl.cpp (right): https://codereview.chromium.org/286263002/diff/1/Source/web/WebDevToolsAgentImpl.cpp#newcode138 Source/web/WebDevToolsAgentImpl.cpp:138: WebDevToolsAgentImpl* agent = static_cast<WebDevToolsAgentImpl*>(view->devToolsAgent()); You should do this ...

6 years, 7 months ago (2014-05-18 06:10:21 UTC) #2

yurys

https://codereview.chromium.org/286263002/diff/1/public/web/WebDevToolsAgentClient.h File public/web/WebDevToolsAgentClient.h (right): https://codereview.chromium.org/286263002/diff/1/public/web/WebDevToolsAgentClient.h#newcode63 public/web/WebDevToolsAgentClient.h:63: virtual void willEnterModalLoop() { } Maybe willEnterDebugLoop?

6 years, 7 months ago (2014-05-19 07:44:41 UTC) #3

dgozman

https://codereview.chromium.org/286263002/diff/1/Source/web/WebDevToolsAgentImpl.cpp File Source/web/WebDevToolsAgentImpl.cpp (right): https://codereview.chromium.org/286263002/diff/1/Source/web/WebDevToolsAgentImpl.cpp#newcode138 Source/web/WebDevToolsAgentImpl.cpp:138: WebDevToolsAgentImpl* agent = static_cast<WebDevToolsAgentImpl*>(view->devToolsAgent()); On 2014/05/18 06:10:22, pfeldman wrote: ...

6 years, 7 months ago (2014-05-19 09:55:48 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/286263002/20001

6 years, 7 months ago (2014-05-20 16:04:02 UTC) #6

Message was sent while issue was closed.

Change committed as 174389

Expand Messages | Collapse Messages