[DevTools] Send ack early when paused in mouse move to keep events coming.

[DevTools] Send ack early when paused in mouse move to keep events coming.

When paused in debugger on mouse move, we can send ack as it has
no side effects apart from new mouse moves being sent to renderer.

Debugger already causes nested input events handling (because of
different event types don't wait for each other's ack). This, and mouse
move being the event without side effects, means there should be
no harm in allowing nested mouse moves.

BUG=374183
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272230

[dgozman, 2014-05-16 14:00:23]

Could you please take a look?

Blink-side using this is https://codereview.chromium.org/286263002/.

[pfeldman, 2014-05-18 06:06:24]

devtools aspectd lgtm w/ nit

[pfeldman, 2014-05-18 06:09:40]

https://codereview.chromium.org/288393004/diff/1/content/renderer/render_widg...
File content/renderer/render_widget.h (right):

https://codereview.chromium.org/288393004/diff/1/content/renderer/render_widg...
content/renderer/render_widget.h:195: bool SendAckForCurrentMouseMove();
SendAckForMouseMoveFromDebugger?

https://codereview.chromium.org/288393004/diff/1/content/renderer/render_widg...
content/renderer/render_widget.h:199: void IgnoreAckForCurrentMouseMove();
ditto

[dgozman, 2014-05-19 09:59:23]

jdduke@, jochen@, please take a look.

https://codereview.chromium.org/288393004/diff/1/content/renderer/render_widg...
File content/renderer/render_widget.h (right):

https://codereview.chromium.org/288393004/diff/1/content/renderer/render_widg...
content/renderer/render_widget.h:195: bool SendAckForCurrentMouseMove();
On 2014/05/18 06:09:40, pfeldman wrote:
> SendAckForMouseMoveFromDebugger?

Done.

https://codereview.chromium.org/288393004/diff/1/content/renderer/render_widg...
content/renderer/render_widget.h:199: void IgnoreAckForCurrentMouseMove();
On 2014/05/18 06:09:40, pfeldman wrote:
> ditto

Done.

[jochen (gone - plz use gerrit), 2014-05-19 13:18:47]

lgtm if jdduke (or somebody else from input) approves

[jdduke (slow), 2014-05-19 15:10:37]

https://codereview.chromium.org/288393004/diff/20001/content/renderer/render_...
File content/renderer/render_widget.cc (right):

https://codereview.chromium.org/288393004/diff/20001/content/renderer/render_...
content/renderer/render_widget.cc:912: handling_event_type_ = input_event->type;
Any reason we can't use base::AutoReset here (also for |handling_input_event_|?

https://codereview.chromium.org/288393004/diff/20001/content/renderer/render_...
content/renderer/render_widget.cc:1983: if (!handling_event_type_ ==
WebInputEvent::TouchStart)
|handling_event_type_ != WebInputEvent::TouchStart)

[dgozman, 2014-05-20 08:54:12]

PTAL

https://codereview.chromium.org/288393004/diff/20001/content/renderer/render_...
File content/renderer/render_widget.cc (right):

https://codereview.chromium.org/288393004/diff/20001/content/renderer/render_...
content/renderer/render_widget.cc:912: handling_event_type_ = input_event->type;
On 2014/05/19 15:10:37, jdduke wrote:
> Any reason we can't use base::AutoReset here (also for
|handling_input_event_|?

Done.

https://codereview.chromium.org/288393004/diff/20001/content/renderer/render_...
content/renderer/render_widget.cc:1983: if (!handling_event_type_ ==
WebInputEvent::TouchStart)
On 2014/05/19 15:10:37, jdduke wrote:
> |handling_event_type_ != WebInputEvent::TouchStart)

Nice catch! Done.

[jdduke (slow), 2014-05-20 14:09:41]

lgtm

[dgozman, 2014-05-22 09:48:21]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2014-05-22 09:49:43]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dgozman@chromium.org/288393004/40001

[commit-bot: I haz the power, 2014-05-22 18:05:23]

Change committed as 272230