md settings: Show lock screen when pin/fingerprint disabled.

md settings: Show lock screen when pin/fingerprint disabled.

Previously lock screen section is only available when pin/fingerprint is enabled. Now easy unlock is moved to the lock screen section we want to just show lock screen section always and hide pin/fingerprint/easy unlock as needed on the lock screen section.

TEST=manual
BUG=717615
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2862613003
Cr-Commit-Position: refs/heads/master@{#470343}
Committed: https://chromium.googlesource.com/chromium/src/+/efd9aa2c88eb30e960c29915dee4e08ea0e7bd97

[sammiequon, 2017-05-03 23:18:29]

Description was changed from

==========
md settings: Show lock screen when pin/fingerprint disabled.

Previously lock screen section is only available when pin/fingerprint is
enabled. Now easy unlock is moved to the lock screen section we want to just
show lock screen section always and hide pin/fingerprint/easy unlock as needed
on the lock screen section.

TEST=manual
BUG=717615
==========

to

==========
md settings: Show lock screen when pin/fingerprint disabled.

Previously lock screen section is only available when pin/fingerprint is
enabled. Now easy unlock is moved to the lock screen section we want to just
show lock screen section always and hide pin/fingerprint/easy unlock as needed
on the lock screen section.

TEST=manual
BUG=717615
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[sammiequon, 2017-05-03 23:18:35]

The CQ bit was checked by sammiequon@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-03 23:19:10]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sammiequon, 2017-05-03 23:50:29]

sammiequon@chromium.org changed reviewers:
+ jdufault@chromium.org

[sammiequon, 2017-05-03 23:50:29]

jdufault@ - Please take a look. Thanks!

[commit-bot: I haz the power, 2017-05-04 00:45:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-04 00:45:08]

Dry run: This issue passed the CQ dry run.

[jdufault, 2017-05-04 21:03:45]

https://codereview.chromium.org/2862613003/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/people_page/lock_screen.js (right):

https://codereview.chromium.org/2862613003/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/people_page/lock_screen.js:65: return
loadTimeData.getBoolean('pinUnlockEnabled');
You should rename the load time data as well.

https://codereview.chromium.org/2862613003/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/people_page/people_page.html (right):

https://codereview.chromium.org/2862613003/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/people_page/people_page.html:249: <template
is="dom-if" if="[[fingerprintUnlockEnabled_]]">
Do we need a dedicated route for setting up fingerprint? Can a user even
navigate directly to fingerprint, ie, because to change fingerprint we need to
also capture the password?

[sammiequon, 2017-05-04 23:32:34]

https://codereview.chromium.org/2862613003/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/people_page/lock_screen.js (right):

https://codereview.chromium.org/2862613003/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/people_page/lock_screen.js:65: return
loadTimeData.getBoolean('pinUnlockEnabled');
On 2017/05/04 21:03:45, jdufault wrote:
> You should rename the load time data as well.

Done.

https://codereview.chromium.org/2862613003/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/people_page/people_page.html (right):

https://codereview.chromium.org/2862613003/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/people_page/people_page.html:249: <template
is="dom-if" if="[[fingerprintUnlockEnabled_]]">
On 2017/05/04 21:03:45, jdufault wrote:
> Do we need a dedicated route for setting up fingerprint? Can a user even
> navigate directly to fingerprint, ie, because to change fingerprint we need to
> also capture the password?

Yeah it's still possible for a user to navigate directly to fingerprint :-(,
haven't got around to that yet.  We can remove this dom-if once that gets
prevented.

[jdufault, 2017-05-04 23:39:03]

https://codereview.chromium.org/2862613003/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/people_page/people_page.html (right):

https://codereview.chromium.org/2862613003/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/people_page/people_page.html:249: <template
is="dom-if" if="[[fingerprintUnlockEnabled_]]">
On 2017/05/04 23:32:34, sammiequon wrote:
> On 2017/05/04 21:03:45, jdufault wrote:
> > Do we need a dedicated route for setting up fingerprint? Can a user even
> > navigate directly to fingerprint, ie, because to change fingerprint we need
to
> > also capture the password?
> 
> Yeah it's still possible for a user to navigate directly to fingerprint :-(,
> haven't got around to that yet.  We can remove this dom-if once that gets
> prevented.

Can we just remove the route entirely? Do we have a reason why the user needs to
be able to navigate directly to fingerprint?

[jdufault, 2017-05-05 00:20:39]

lgtm after offline discussion; the plan is to reroute fingerprint settings to
lock screen but we need the route for technical reasons.

[sammiequon, 2017-05-05 23:23:12]

Description was changed from

==========
md settings: Show lock screen when pin/fingerprint disabled.

Previously lock screen section is only available when pin/fingerprint is
enabled. Now easy unlock is moved to the lock screen section we want to just
show lock screen section always and hide pin/fingerprint/easy unlock as needed
on the lock screen section.

TEST=manual
BUG=717615
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
md settings: Show lock screen when pin/fingerprint disabled.

Previously lock screen section is only available when pin/fingerprint is
enabled. Now easy unlock is moved to the lock screen section we want to just
show lock screen section always and hide pin/fingerprint/easy unlock as needed
on the lock screen section.

TEST=manual
BUG=717615
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[sammiequon, 2017-05-05 23:23:12]

sammiequon@chromium.org changed reviewers:
+ stevenjb@chromium.org

[sammiequon, 2017-05-05 23:23:34]

On 2017/05/05 00:20:39, jdufault wrote:
> lgtm after offline discussion; the plan is to reroute fingerprint settings to
> lock screen but we need the route for technical reasons.

Thanks! 

stevenjb@ - Please take a look. Thanks!

[stevenjb, 2017-05-08 18:43:07]

lgtm w/ one comment/suggestion

https://codereview.chromium.org/2862613003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/people_page/lock_screen.js (right):

https://codereview.chromium.org/2862613003/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/people_page/lock_screen.js:236: if
(this.hasPin)
Because this is called inside a <template> it is safer to use passed properties
instead of this.* due to the way 'this' behaves in templates. (The specifics are
complicated and I don't recall the details; michaelpg@ should know if you're
interested).

[sammiequon, 2017-05-08 20:40:53]

Thanks!

https://codereview.chromium.org/2862613003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/people_page/lock_screen.js (right):

https://codereview.chromium.org/2862613003/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/people_page/lock_screen.js:236: if
(this.hasPin)
On 2017/05/08 18:43:07, stevenjb wrote:
> Because this is called inside a <template> it is safer to use passed
properties
> instead of this.* due to the way 'this' behaves in templates. (The specifics
are
> complicated and I don't recall the details; michaelpg@ should know if you're
> interested).

Done.

[sammiequon, 2017-05-08 20:41:02]

The CQ bit was checked by sammiequon@chromium.org

[sammiequon, 2017-05-08 20:41:02]

The patchset sent to the CQ was uploaded after l-g-t-m from
jdufault@chromium.org, stevenjb@chromium.org
Link to the patchset: https://codereview.chromium.org/2862613003/#ps40001
(title: "Fix patch set 2 errors.")

[commit-bot: I haz the power, 2017-05-08 20:42:05]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-08 20:45:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-08 20:45:43]

Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[sammiequon, 2017-05-08 21:08:15]

The CQ bit was checked by sammiequon@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-08 21:09:29]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-09 03:41:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-09 03:41:13]

Dry run: This issue passed the CQ dry run.

[sammiequon, 2017-05-09 15:28:46]

The CQ bit was checked by sammiequon@chromium.org

[commit-bot: I haz the power, 2017-05-09 15:29:16]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-09 15:34:42]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1494343726763340,
"parent_rev": "fafd641b6e5cc2a0e16d13054fd74f94f1a08fc3", "commit_rev":
"efd9aa2c88eb30e960c29915dee4e08ea0e7bd97"}

[commit-bot: I haz the power, 2017-05-09 15:34:52]

Description was changed from

==========
md settings: Show lock screen when pin/fingerprint disabled.

Previously lock screen section is only available when pin/fingerprint is
enabled. Now easy unlock is moved to the lock screen section we want to just
show lock screen section always and hide pin/fingerprint/easy unlock as needed
on the lock screen section.

TEST=manual
BUG=717615
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
md settings: Show lock screen when pin/fingerprint disabled.

Previously lock screen section is only available when pin/fingerprint is
enabled. Now easy unlock is moved to the lock screen section we want to just
show lock screen section always and hide pin/fingerprint/easy unlock as needed
on the lock screen section.

TEST=manual
BUG=717615
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2862613003
Cr-Commit-Position: refs/heads/master@{#470343}
Committed:
https://chromium.googlesource.com/chromium/src/+/efd9aa2c88eb30e960c29915dee4...
==========

[commit-bot: I haz the power, 2017-05-09 15:34:54]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/efd9aa2c88eb30e960c29915dee4...