Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 2862603003: Revert of DevTools: Roll CodeMirror to 5.25.1

Created:
3 years, 7 months ago by einbinder
Modified:
3 years, 7 months ago
Reviewers:
lushnikov
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of DevTools: Roll CodeMirror to 5.25.1 (patchset #2 id:20001 of https://codereview.chromium.org/2772343006/ ) Reason for revert: Poor performance on long bidi lines. Original issue's description: > DevTools: Roll CodeMirror to 5.25.1 > > This mainly to fix bugs where line numbers appear outside the gutter. > This patch also removes the SimpleMode since it was never used. > > BUG=none > R=lushnikov@chromium.org > > Review-Url: https://codereview.chromium.org/2772343006 . > Cr-Commit-Position: refs/heads/master@{#460469} > Committed: https://chromium.googlesource.com/chromium/src/+/02128266dda94d175c6e4070a7f67b6232d6ae03 TBR=lushnikov@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=none

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9073 lines, -9267 lines) Patch
M third_party/WebKit/Source/devtools/front_end/cm/LICENSE View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/cm/activeline.js View 3 chunks +13 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/cm/closebrackets.js View 4 chunks +4 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/cm/codemirror.css View 5 chunks +13 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/cm/codemirror.js View 3 chunks +8745 lines, -9110 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/cm/comment.js View 6 chunks +12 lines, -22 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/cm/markselection.js View 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/cm/matchbrackets.js View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/cm/overlay.js View 1 chunk +2 lines, -7 lines 0 comments Download
A third_party/WebKit/Source/devtools/front_end/cm/simple.js View 1 chunk +213 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/cm_modes/clike.js View 8 chunks +13 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/cm_modes/jsx.js View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/cm_modes/livescript.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/cm_modes/python.js View 6 chunks +10 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/cm_modes/shell.js View 4 chunks +10 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/cm_modes/stylus.js View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/cm_web_modes/css.js View 15 chunks +12 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/cm_web_modes/htmlmixed.js View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/cm_web_modes/javascript.js View 8 chunks +11 lines, -29 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/externs.js View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
einbinder
Created Revert of DevTools: Roll CodeMirror to 5.25.1
3 years, 7 months ago (2017-05-04 01:08:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2862603003/1
3 years, 7 months ago (2017-05-04 01:08:43 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/376194)
3 years, 7 months ago (2017-05-04 02:23:46 UTC) #5
lushnikov
3 years, 7 months ago (2017-05-04 20:32:22 UTC) #6
Let's annotate this with a proper BUG number.
Also, it looks like more changes are required since trybots failed

Powered by Google App Engine
This is Rietveld 408576698