Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2772343006: DevTools: Roll CodeMirror to 5.25.1 (Closed)

Created:
3 years, 8 months ago by einbinder
Modified:
3 years, 8 months ago
Reviewers:
lushnikov
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Roll CodeMirror to 5.25.1 This mainly to fix bugs where line numbers appear outside the gutter. This patch also removes the SimpleMode since it was never used. BUG=none R=lushnikov@chromium.org Review-Url: https://codereview.chromium.org/2772343006 . Cr-Commit-Position: refs/heads/master@{#460469} Committed: https://chromium.googlesource.com/chromium/src/+/02128266dda94d175c6e4070a7f67b6232d6ae03

Patch Set 1 #

Patch Set 2 : stray space #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9293 lines, -9099 lines) Patch
M third_party/WebKit/Source/devtools/front_end/cm/LICENSE View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/cm/activeline.js View 3 chunks +11 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/cm/closebrackets.js View 4 chunks +11 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/cm/codemirror.css View 5 chunks +6 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/cm/codemirror.js View 1 1 chunk +9137 lines, -8772 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/cm/comment.js View 6 chunks +21 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/cm/markselection.js View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/cm/matchbrackets.js View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/cm/overlay.js View 1 chunk +7 lines, -2 lines 0 comments Download
D third_party/WebKit/Source/devtools/front_end/cm/simple.js View 1 chunk +0 lines, -213 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/cm_modes/clike.js View 8 chunks +14 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/cm_modes/jsx.js View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/cm_modes/livescript.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/cm_modes/python.js View 6 chunks +10 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/cm_modes/shell.js View 4 chunks +14 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/cm_modes/stylus.js View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/cm_web_modes/css.js View 15 chunks +18 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/cm_web_modes/htmlmixed.js View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/cm_web_modes/javascript.js View 9 chunks +29 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/externs.js View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 19 (14 generated)
lushnikov
3 years, 8 months ago (2017-03-29 01:05:33 UTC) #4
lushnikov
lgtm
3 years, 8 months ago (2017-03-29 18:39:33 UTC) #15
lushnikov
lgtm
3 years, 8 months ago (2017-03-29 18:39:33 UTC) #16
lushnikov
Committed patchset #2 (id:20001) manually as 02128266dda94d175c6e4070a7f67b6232d6ae03 (presubmit successful).
3 years, 8 months ago (2017-03-29 18:41:41 UTC) #18
einbinder
3 years, 7 months ago (2017-05-04 01:08:12 UTC) #19
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2862603003/ by einbinder@chromium.org.

The reason for reverting is: Poor performance on long bidi lines..

Powered by Google App Engine
This is Rietveld 408576698