Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7211)

Unified Diff: chrome/browser/renderer_context_menu/render_view_context_menu.cc

Issue 2862583010: [Reland 1] Save pdf file instead of web page through context menu for embedded pdf file (Closed)
Patch Set: fix file path Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/renderer_context_menu/render_view_context_menu.cc
diff --git a/chrome/browser/renderer_context_menu/render_view_context_menu.cc b/chrome/browser/renderer_context_menu/render_view_context_menu.cc
index 5a7909e0c5c698a98914021b56cf0bca8845a32e..7fc60cb7b9f7cbe7eb565698b4af41248fbb5d75 100644
--- a/chrome/browser/renderer_context_menu/render_view_context_menu.cc
+++ b/chrome/browser/renderer_context_menu/render_view_context_menu.cc
@@ -1171,7 +1171,8 @@ void RenderViewContextMenu::AppendMediaItems() {
void RenderViewContextMenu::AppendPluginItems() {
if (params_.page_url == params_.src_url ||
- guest_view::GuestViewBase::IsGuest(source_web_contents_)) {
+ (guest_view::GuestViewBase::IsGuest(source_web_contents_) &&
+ !embedder_web_contents_->IsSavable())) {
lazyboy 2017/05/11 18:15:17 Can you add comments to explain this a bit? Someth
Wei Li 2017/05/17 05:37:09 Done.
// Full page plugin, so show page menu items.
if (params_.link_url.is_empty() && params_.selection_text.empty())
AppendPageItems();

Powered by Google App Engine
This is Rietveld 408576698