[Reland 1] Save pdf file instead of web page through context menu for embedded pdf file

chrome/browser/renderer_context_menu/render_view_context_menu.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/renderer_context_menu/render_view_context_menu.h"
 
 #include <stddef.h>
 
 #include <algorithm>
 #include <set>
@@ skipping 1153 matching lines @@
 
 void RenderViewContextMenu::AppendMediaItems() {
   menu_model_.AddCheckItemWithStringId(IDC_CONTENT_CONTEXT_LOOP,
                                        IDS_CONTENT_CONTEXT_LOOP);
   menu_model_.AddCheckItemWithStringId(IDC_CONTENT_CONTEXT_CONTROLS,
                                        IDS_CONTENT_CONTEXT_CONTROLS);
 }
 
 void RenderViewContextMenu::AppendPluginItems() {
   if (params_.page_url == params_.src_url ||
-      guest_view::GuestViewBase::IsGuest(source_web_contents_)) {
+      (guest_view::GuestViewBase::IsGuest(source_web_contents_) &&
+       !embedder_web_contents_->IsSavable())) {

[lazyboy, 2017/05/11 18:15:17]

Can you add comments to explain this a bit? Something like:
// Full page pdf -> embedder is not savable, so we potentially show page items.
Otherwise we default to plugin items.
!embedder_web_contents_->IsSavable()

Also you can verify whether ^^^ is correct :)

[Wei Li, 2017/05/17 05:37:09]

Done.

     // Full page plugin, so show page menu items.
     if (params_.link_url.is_empty() && params_.selection_text.empty())
       AppendPageItems();
   } else {
     menu_model_.AddItemWithStringId(IDC_CONTENT_CONTEXT_SAVEAVAS,
                                     IDS_CONTENT_CONTEXT_SAVEPAGEAS);
     // The "Print" menu item should always be included for plugins. If
     // content_type_->SupportsGroup(ContextMenuContentType::ITEM_GROUP_PRINT)
     // is true the item will be added inside AppendPrintItem(). Otherwise we
     // add "Print" here.
@@ skipping 1269 matching lines @@
 void RenderViewContextMenu::PluginActionAt(
     const gfx::Point& location,
     const WebPluginAction& action) {
   source_web_contents_->GetRenderViewHost()->
       ExecutePluginActionAtLocation(location, action);
 }
 
 Browser* RenderViewContextMenu::GetBrowser() const {
   return chrome::FindBrowserWithWebContents(embedder_web_contents_);
 }