chrome/test/data/pdf/test-embed-pdf.html - Issue 2862583010: [Reland 1] Save pdf file instead of web page through context menu for embedded pdf file

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/pdf/test-embed-pdf.html

Issue 2862583010: [Reland 1] Save pdf file instead of web page through context menu for embedded pdf file (Closed)

Patch Set: fix flaky tests Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <html>

	2 <body>

	3

	4 <button id="link1" onclick="openPdf()">Click me to load pdf</button>

	5 <div id="div1"></div>
	lazyboy 2017/05/17 16:34:44 nit:s/div1/container (in both html) nit:s/div1/container (in both html) Wei Li 2017/05/18 23:25:28 Done. Show quoted text On 2017/05/17 16:34:44, lazyboy wrote: > nit:s/div1/container (in both html) Done.
	6

	7 <script>

	8 function openPdf() {

	9 var frame = document.createElement("embed");
	lazyboy 2017/05/17 16:34:44 Since this is not a frame, call it embedElement or Since this is not a frame, call it embedElement or something. Wei Li 2017/05/18 23:25:28 Done. Show quoted text On 2017/05/17 16:34:44, lazyboy wrote: > Since this is not a frame, call it embedElement or something. Done.
	10 frame.src = "test.pdf";

	11 var outter_element = document.getElementById("div1");
	lazyboy 2017/05/17 16:34:44 nit: outerElement (also applies to other file). nit: outerElement (also applies to other file). Wei Li 2017/05/18 23:25:28 Done. Show quoted text On 2017/05/17 16:34:44, lazyboy wrote: > nit: outerElement (also applies to other file). Done.
	12 outter_element.appendChild(frame);

	13 }

	14 </script>

	15

	16 <body>

	17 </html>

OLD	NEW