Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(309)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: chrome/test/data/pdf/test-iframe-pdf.html
Issue
2862583010
:
[Reland 1] Save pdf file instead of web page through context menu for embedded pdf file (Closed)
Patch Set: fix flaky tests
Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
chrome/browser/renderer_context_menu/render_view_context_menu.cc
chrome/browser/renderer_context_menu/render_view_context_menu_browsertest.cc
chrome/test/data/pdf/test-embed-pdf.html
chrome/test/data/pdf/test-iframe-pdf.html
View unified diff
|
Download patch
« chrome/test/data/pdf/test-embed-pdf.html
('K') |
« chrome/test/data/pdf/test-embed-pdf.html
('k') |
no next file »
|
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
<html>
2
<body>
3
4
<button id="link1" onclick="openPdf()">Click me to load pdf</button>
5
<div id="div1"></div>
6
7
<script>
8
function openPdf() {
9
var frame = document.createElement("iframe");
10
frame.src = "test.pdf";
11
var outter_element = document.getElementById("div1");
12
outter_element.appendChild(frame);
13
}
14
</script>
15
16
<body>
17
</html>
OLD
NEW
« chrome/test/data/pdf/test-embed-pdf.html
('K') |
« chrome/test/data/pdf/test-embed-pdf.html
('k') |
no next file »
|
no next file with comments »
Issue 2862583010: [Reland 1] Save pdf file instead of web page through context menu for embedded pdf file (Closed)
Created 3 years, 7 months ago by Wei Li
Modified 3 years, 7 months ago
Reviewers: lazyboy
Base URL:
Comments: 17
This is Rietveld
408576698