Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Issue 2862583009: [WebView global interface listing] Mark Web Payments as not exposed (Closed)

Created:
3 years, 7 months ago by johnme
Modified:
3 years, 7 months ago
CC:
chromium-reviews, danakj+watch_chromium.org, android-webview-reviews_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[WebView global interface listing] Mark Web Payments as not exposed Fix WebViewLayoutTest#testWebViewIncludedStableInterfaces which is currently failing because the Web Payments API is not currently supported on WebView (crbug.com/667069), but was missing from the list of APIs expected to be missing. BUG=667069, 717914 TBR=rouslan@chromium.org,zkoch@chromium.org,timvolodine@chromium.org NOTRY=true SKIPTREECHECKS=true Review-Url: https://codereview.chromium.org/2862583009 Cr-Commit-Position: refs/heads/master@{#469665} Committed: https://chromium.googlesource.com/chromium/src/+/948317e5fe39e679b776bfd732dd50c4215bd191

Patch Set 1 #

Patch Set 2 : Remove spurious file from CL #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M android_webview/tools/system_webview_shell/test/data/webexposed/not-webview-exposed.txt View 2 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2862583009/20001
3 years, 7 months ago (2017-05-05 15:52:38 UTC) #2
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/948317e5fe39e679b776bfd732dd50c4215bd191
3 years, 7 months ago (2017-05-05 15:59:26 UTC) #5
timvolodine
3 years, 7 months ago (2017-05-05 17:01:49 UTC) #6
Message was sent while issue was closed.
lgtm, thanks John!

Powered by Google App Engine
This is Rietveld 408576698