Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1156)

Issue 2862583005: Update the Speak answers back switch item. (Closed)

Created:
3 years, 7 months ago by lpromero
Modified:
3 years, 7 months ago
Reviewers:
sczs
CC:
chromium-reviews, marq+watch_chromium.org, ios-reviews+chrome_chromium.org, noyau+watch_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Update the Speak answers back switch item. BUG=717483 R=sczs@chromium.org TEST=See steps in bug. Review-Url: https://codereview.chromium.org/2862583005 Cr-Commit-Position: refs/heads/master@{#469348} Committed: https://chromium.googlesource.com/chromium/src/+/644d16e85e314eea64abdb2ebd30b11ed731f5c9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M ios/chrome/browser/ui/settings/voicesearch_collection_view_controller.mm View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
lpromero
3 years, 7 months ago (2017-05-04 13:35:23 UTC) #1
sczs
lgtm
3 years, 7 months ago (2017-05-04 15:58:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2862583005/1
3 years, 7 months ago (2017-05-04 15:59:21 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-05-04 16:03:26 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/644d16e85e314eea64abdb2ebd30...

Powered by Google App Engine
This is Rietveld 408576698