Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 2862583004: Initialize libxml to observe effects on the Android crash. (Closed)

Created:
3 years, 7 months ago by Sorin Jianu
Modified:
3 years, 7 months ago
Reviewers:
waffles
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Initialize libxml to observe effects on the Android crash. BUG=717889 Review-Url: https://codereview.chromium.org/2862583004 Cr-Commit-Position: refs/heads/master@{#469162} Committed: https://chromium.googlesource.com/chromium/src/+/2d8fe91e57658a49b85c04a2c61c1a5130ba77de

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M components/update_client/update_client.cc View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
Sorin Jianu
PTAL!
3 years, 7 months ago (2017-05-03 21:22:35 UTC) #4
waffles
lgtm
3 years, 7 months ago (2017-05-03 21:25:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2862583004/1
3 years, 7 months ago (2017-05-03 21:31:05 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/2d8fe91e57658a49b85c04a2c61c1a5130ba77de
3 years, 7 months ago (2017-05-03 22:19:20 UTC) #11
Sorin Jianu
3 years, 7 months ago (2017-05-05 16:55:53 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2864573003/ by sorin@chromium.org.

The reason for reverting is: It does not seem to have an impact on stability..

Powered by Google App Engine
This is Rietveld 408576698