DescriptionRevert of [Media Router] Custom Controls 3 - add plumbing through MRUI and MRWebUIMessageHandler (patchset #11 id:360001 of https://codereview.chromium.org/2731033002/ )
Reason for revert:
Breaks unit_tests on all OSes:
https://build.chromium.org/p/chromium.win/builders/Win10%20Tests%20x64/builds/11182/steps/unit_tests%20on%20Windows-10-10586
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/38007/steps/unit_tests
https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests/builds/40693/steps/unit_tests
Original issue's description:
> [Media Router] Custom Controls 3 - add plumbing through MRUI and
> MRWebUIMessageHandler
>
> When the route details view is opened, MediaRouterUI will instantiate an
> observer for the controller obtained via MediaRouter::GetRouteController().
> MediaRouterUI will send media commands (e.g. play/pause) to the controller
> through the reference held by the observer. The observer will be destroyed when
> the route details view is closed.
>
> MediaRouterWebUIMessageHandler will parse media commands from the WebUI and pass
> them on to MediaRouterUI. It will also forward status updates from the
> controller observer to the WebUI.
>
>
> The Chromium-side implementation of custom controls will be done in these
> patches:
> 1. Mojo/MediaStatus/MediaRouteController: http://crrev/2727123002
> 2. MediaRouter::GetRouteController(): http://crrev/2728543009
> 3. MRUI/MRWebUIMessageHandler: this patch
> 4. Custom controls WebUI: http://crrev/2725503002
>
> Custom controls design doc:
> https://docs.google.com/document/d/1_8QxdFIiiJX39jR1Wi1Zn9FW-Y66EMvX1GmQZvjN4G0/edit
>
> BUG=684638
>
> Review-Url: https://codereview.chromium.org/2731033002
> Cr-Commit-Position: refs/heads/master@{#468864}
> Committed: https://chromium.googlesource.com/chromium/src/+/e91ca334b8194bc324044057aa6b9f8bf898b1a7
TBR=mfoltz@chromium.org,imcheng@chromium.org,takumif@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=684638
Review-Url: https://codereview.chromium.org/2862513002
Cr-Commit-Position: refs/heads/master@{#468915}
Committed: https://chromium.googlesource.com/chromium/src/+/636a9d194006073485edfa89533c1076dc1b0206
Patch Set 1 #Messages
Total messages: 7 (3 generated)
|