Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 2862513002: Revert of [Media Router] Custom Controls 3 - add plumbing through MRUI and MRWebUIMessageHandler (Closed)

Created:
3 years, 7 months ago by msramek
Modified:
3 years, 7 months ago
CC:
chromium-reviews, media-router+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Media Router] Custom Controls 3 - add plumbing through MRUI and MRWebUIMessageHandler (patchset #11 id:360001 of https://codereview.chromium.org/2731033002/ ) Reason for revert: Breaks unit_tests on all OSes: https://build.chromium.org/p/chromium.win/builders/Win10%20Tests%20x64/builds/11182/steps/unit_tests%20on%20Windows-10-10586 https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/38007/steps/unit_tests https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests/builds/40693/steps/unit_tests Original issue's description: > [Media Router] Custom Controls 3 - add plumbing through MRUI and > MRWebUIMessageHandler > > When the route details view is opened, MediaRouterUI will instantiate an > observer for the controller obtained via MediaRouter::GetRouteController(). > MediaRouterUI will send media commands (e.g. play/pause) to the controller > through the reference held by the observer. The observer will be destroyed when > the route details view is closed. > > MediaRouterWebUIMessageHandler will parse media commands from the WebUI and pass > them on to MediaRouterUI. It will also forward status updates from the > controller observer to the WebUI. > > > The Chromium-side implementation of custom controls will be done in these > patches: > 1. Mojo/MediaStatus/MediaRouteController: http://crrev/2727123002 > 2. MediaRouter::GetRouteController(): http://crrev/2728543009 > 3. MRUI/MRWebUIMessageHandler: this patch > 4. Custom controls WebUI: http://crrev/2725503002 > > Custom controls design doc: > https://docs.google.com/document/d/1_8QxdFIiiJX39jR1Wi1Zn9FW-Y66EMvX1GmQZvjN4G0/edit > > BUG=684638 > > Review-Url: https://codereview.chromium.org/2731033002 > Cr-Commit-Position: refs/heads/master@{#468864} > Committed: https://chromium.googlesource.com/chromium/src/+/e91ca334b8194bc324044057aa6b9f8bf898b1a7 TBR=mfoltz@chromium.org,imcheng@chromium.org,takumif@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=684638 Review-Url: https://codereview.chromium.org/2862513002 Cr-Commit-Position: refs/heads/master@{#468915} Committed: https://chromium.googlesource.com/chromium/src/+/636a9d194006073485edfa89533c1076dc1b0206

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+379 lines, -767 lines) Patch
M chrome/browser/media/router/mojo/media_route_controller.h View 2 chunks +7 lines, -8 lines 0 comments Download
M chrome/browser/media/router/mojo/media_route_controller.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/media/router/mojo/media_router_mojo_test.h View 1 chunk +0 lines, -17 lines 0 comments Download
M chrome/browser/media/router/mojo/media_router_mojo_test.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M chrome/browser/ui/webui/media_router/media_router_ui.h View 11 chunks +6 lines, -50 lines 0 comments Download
M chrome/browser/ui/webui/media_router/media_router_ui.cc View 3 chunks +0 lines, -50 lines 0 comments Download
M chrome/browser/ui/webui/media_router/media_router_ui_unittest.cc View 5 chunks +4 lines, -65 lines 0 comments Download
M chrome/browser/ui/webui/media_router/media_router_webui_message_handler.h View 5 chunks +0 lines, -26 lines 0 comments Download
M chrome/browser/ui/webui/media_router/media_router_webui_message_handler.cc View 7 chunks +1 line, -150 lines 0 comments Download
M chrome/browser/ui/webui/media_router/media_router_webui_message_handler_unittest.cc View 11 chunks +356 lines, -379 lines 0 comments Download
M chrome/common/chrome_features.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_features.cc View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
msramek
Created Revert of [Media Router] Custom Controls 3 - add plumbing through MRUI and MRWebUIMessageHandler
3 years, 7 months ago (2017-05-03 07:13:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2862513002/1
3 years, 7 months ago (2017-05-03 07:13:39 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/636a9d194006073485edfa89533c1076dc1b0206
3 years, 7 months ago (2017-05-03 07:14:20 UTC) #6
mark a. foltz
3 years, 7 months ago (2017-05-03 16:53:28 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698