Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 2862503002: [SmartText Selecton] Increase the number of extra characters to 240 (Closed)

Created:
3 years, 7 months ago by Tima Vaisburd
Modified:
3 years, 7 months ago
CC:
chromium-reviews, jam, darin-cc_chromium.org, agrieve+watch_chromium.org, Theresa, Donn Denman
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[SmartText Selecton] Increase the number of extra characters to 240 This is the maximal amount of characters from the left and from the right taken together, i.e. there is 120 on each side. BUG=717619 Review-Url: https://codereview.chromium.org/2862503002 Cr-Commit-Position: refs/heads/master@{#469019} Committed: https://chromium.googlesource.com/chromium/src/+/a999e72fd81a030338d60785a2e6e09427fad811

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/public/android/java/src/org/chromium/content/browser/ContextSelectionClient.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
Tima Vaisburd
PTAL
3 years, 7 months ago (2017-05-03 05:00:10 UTC) #2
boliu
+donnd: is this ok for contextual search?
3 years, 7 months ago (2017-05-03 16:02:14 UTC) #4
Tima Vaisburd
On 2017/05/03 16:02:14, boliu wrote: > +donnd: is this ok for contextual search? As far ...
3 years, 7 months ago (2017-05-03 16:28:49 UTC) #5
boliu
lgtm
3 years, 7 months ago (2017-05-03 16:44:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2862503002/1
3 years, 7 months ago (2017-05-03 16:46:05 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-05-03 17:29:51 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a999e72fd81a030338d60785a2e6...

Powered by Google App Engine
This is Rietveld 408576698