[Android WebAPKs] Add UMA metric for ShellAPK version

[Android WebAPKs] Add UMA metric for ShellAPK version

This CL adds a UMA metric for the ShellAPK version. The metric will tell us the
percentage of users with WebAPKs with a given ShellAPK version.

There is a separate metric for "Google Play WebAPKs" and "Browser WebAPKs". We
expect the ShellAPK for "Unbound WebAPKs" to be permanently out of date. We
hope that the ShellAPK for "Browser WebAPKs" stays up to date

BUG=691743
Review-Url: https://codereview.chromium.org/2862493002
Cr-Commit-Position: refs/heads/master@{#470756}
Committed: https://chromium.googlesource.com/chromium/src/+/7ff54f9912ee3dd2132e0fc7c1e9bdadc06b46b1

[pkotwicz, 2017-05-03 04:58:07]

pkotwicz@chromium.org changed reviewers:
+ hanxi@chromium.org

[pkotwicz, 2017-05-03 04:58:08]

Xi can you please take a look?

[Xi Han, 2017-05-03 13:34:12]

Thanks for writing the CL, lgtm!

[Yaron, 2017-05-03 15:24:44]

yfriedman@chromium.org changed reviewers:
+ yfriedman@chromium.org

[Yaron, 2017-05-03 15:24:45]

lgtm

https://codereview.chromium.org/2862493002/diff/1/chrome/android/java/src/org...
File chrome/android/java/src/org/chromium/chrome/browser/metrics/WebApkUma.java
(right):

https://codereview.chromium.org/2862493002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/metrics/WebApkUma.java:103:
? "WebApk.ShellApkVersion.BrowserAPK"
nit: BrowserApk (to be consistent with everything else - i.e. WebApk and
ShellApk) and UnboundApk

[pkotwicz, 2017-05-04 19:10:29]

Description was changed from

==========
[Android WebAPKs] Add UMA metric for ShellAPK version

This CL adds a UMA metric for the ShellAPK version. The metric will tell us the
percentage of users with WebAPKs with a given ShellAPK version.

There is a separate metric for "Google Play WebAPKs" and "Browser WebAPKs". We
expect the ShellAPK for "Google Play WebAPKs" to be permanently out of date. We
hope that the ShellAPK for "Browser WebAPKs" stays up to date

BUG=691743
==========

to

==========
[Android WebAPKs] Add UMA metric for ShellAPK version

This CL adds a UMA metric for the ShellAPK version. The metric will tell us the
percentage of users with WebAPKs with a given ShellAPK version.

There is a separate metric for "Google Play WebAPKs" and "Browser WebAPKs". We
expect the ShellAPK for "Unbound WebAPKs" to be permanently out of date. We
hope that the ShellAPK for "Browser WebAPKs" stays up to date

BUG=691743
==========

[pkotwicz, 2017-05-04 19:12:47]

pkotwicz@chromium.org changed reviewers:
+ isherman@chromium.org

[pkotwicz, 2017-05-04 19:12:47]

isherman@ can you please take a look at the changes in tools/metrics/histograms

[Ilya Sherman, 2017-05-04 19:55:08]

https://codereview.chromium.org/2862493002/diff/20001/chrome/android/java/src...
File chrome/android/java/src/org/chromium/chrome/browser/metrics/WebApkUma.java
(right):

https://codereview.chromium.org/2862493002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/metrics/WebApkUma.java:105:
RecordHistogram.recordCountHistogram(name, shellApkVersion);
This probably makes more sense as a sparse histogram, since you probably want to
see individual version numbers.

https://codereview.chromium.org/2862493002/diff/20001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2862493002/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:78505: +    Only recorded for WebAPKs
installed by Chrome.
Could you add a link to some documentation on how to understand Shell APK
versions?  (Alternately, would it make sense to associate an enum attribute with
this histogram?)

https://codereview.chromium.org/2862493002/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:78509: +<histogram
name="WebApk.ShellApkVersion.UnboundApk">
Optional: You could use a histogram_suffixes element to avoid copy/pasting some
of this metadata.  The savings are pretty minor in this particular case, though.

[pkotwicz, 2017-05-05 21:25:41]

Patchset #4 (id:60001) has been deleted

[pkotwicz, 2017-05-05 21:25:55]

Patchset #3 (id:40001) has been deleted

[pkotwicz, 2017-05-05 21:26:24]

isherman@ can you please take another look?

https://codereview.chromium.org/2862493002/diff/20001/chrome/android/java/src...
File chrome/android/java/src/org/chromium/chrome/browser/metrics/WebApkUma.java
(right):

https://codereview.chromium.org/2862493002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/metrics/WebApkUma.java:105:
RecordHistogram.recordCountHistogram(name, shellApkVersion);
Good point! Changed.

https://codereview.chromium.org/2862493002/diff/20001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2862493002/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:78505: +    Only recorded for WebAPKs
installed by Chrome.
I now mention chrome/android/webapk/shell_apk/shell_apk_version.gni in the
histogram. That file contains documentation about the version

[Ilya Sherman, 2017-05-05 22:46:52]

LGTM % comments

https://codereview.chromium.org/2862493002/diff/80001/chrome/android/java/src...
File chrome/android/java/src/org/chromium/chrome/browser/metrics/WebApkUma.java
(right):

https://codereview.chromium.org/2862493002/diff/80001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/metrics/WebApkUma.java:105:
RecordHistogram.recordCountHistogram(name, shellApkVersion);
I think you wanted to update this line to record a sparse histogram, rather than
changing the call in WebApkActivity ;-)

https://codereview.chromium.org/2862493002/diff/80001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2862493002/diff/80001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:78979: +<histogram
name="WebApk.ShellApkVersion">
nit: Please add the attribute base="true", as this histogram name is not a
complete name on its own.

[pkotwicz, 2017-05-10 19:19:35]

The CQ bit was checked by pkotwicz@chromium.org

[pkotwicz, 2017-05-10 19:19:36]

The patchset sent to the CQ was uploaded after l-g-t-m from hanxi@chromium.org,
yfriedman@chromium.org, isherman@chromium.org
Link to the patchset: https://codereview.chromium.org/2862493002/#ps120001
(title: "Merge branch 'master' into metric")

[commit-bot: I haz the power, 2017-05-10 19:21:31]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 19:36:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 19:36:09]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Yaron, 2017-05-10 19:49:07]

The CQ bit was checked by yfriedman@chromium.org

[commit-bot: I haz the power, 2017-05-10 19:50:54]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 23:57:10]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1494445747980620,
"parent_rev": "43535f1beb4135a9f860fdae5b99ec0a5e4e9374", "commit_rev":
"7ff54f9912ee3dd2132e0fc7c1e9bdadc06b46b1"}

[commit-bot: I haz the power, 2017-05-10 23:57:20]

Description was changed from

==========
[Android WebAPKs] Add UMA metric for ShellAPK version

This CL adds a UMA metric for the ShellAPK version. The metric will tell us the
percentage of users with WebAPKs with a given ShellAPK version.

There is a separate metric for "Google Play WebAPKs" and "Browser WebAPKs". We
expect the ShellAPK for "Unbound WebAPKs" to be permanently out of date. We
hope that the ShellAPK for "Browser WebAPKs" stays up to date

BUG=691743
==========

to

==========
[Android WebAPKs] Add UMA metric for ShellAPK version

This CL adds a UMA metric for the ShellAPK version. The metric will tell us the
percentage of users with WebAPKs with a given ShellAPK version.

There is a separate metric for "Google Play WebAPKs" and "Browser WebAPKs". We
expect the ShellAPK for "Unbound WebAPKs" to be permanently out of date. We
hope that the ShellAPK for "Browser WebAPKs" stays up to date

BUG=691743

Review-Url: https://codereview.chromium.org/2862493002
Cr-Commit-Position: refs/heads/master@{#470756}
Committed:
https://chromium.googlesource.com/chromium/src/+/7ff54f9912ee3dd2132e0fc7c1e9...
==========

[commit-bot: I haz the power, 2017-05-10 23:57:21]

Committed patchset #5 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/7ff54f9912ee3dd2132e0fc7c1e9...