components/autofill/core/browser/autofill_external_delegate.h - Issue 286243002: Mac: Autofill should not immediately request access to address book.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/autofill_external_delegate.h

Issue 286243002: Mac: Autofill should not immediately request access to address book. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address second round of comments from isherman. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill.gypi ('k') | components/autofill/core/browser/autofill_external_delegate.cc » ('j') | components/autofill/core/browser/autofill_external_delegate.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/autofill_external_delegate.h

diff --git a/components/autofill/core/browser/autofill_external_delegate.h b/components/autofill/core/browser/autofill_external_delegate.h

index 672b2d63d18955557b72fa32fb7a86cbb7f57b67..f81771162bd5cb6517abfd1fee1c9cd93342c582 100644

--- a/components/autofill/core/browser/autofill_external_delegate.h

+++ b/components/autofill/core/browser/autofill_external_delegate.h

@@ -142,6 +142,12 @@ class AutofillExternalDelegate

std::vector<base::string16> data_list_values_;

std::vector<base::string16> data_list_labels_;

+#if defined(OS_MACOSX)

+ // If this property is set, then the autofill popup should be immediately

+ // redisplayed when the text field loses focus.

+ bool redisplay_autofill_;

Ilya Sherman 2014/05/22 15:13:59 nit: Perhaps "redisplay_popop_on_focus_lost_" or s

erikchen 2014/05/22 20:40:59 I've changed the property name to your suggestion.

+#endif

base::WeakPtrFactory<AutofillExternalDelegate> weak_ptr_factory_;

DISALLOW_COPY_AND_ASSIGN(AutofillExternalDelegate);