Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Side by Side Diff: components/autofill/core/browser/autofill_external_delegate.h

Issue 286243002: Mac: Autofill should not immediately request access to address book. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address second round of comments from isherman. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_EXTERNAL_DELEGATE_H_ 5 #ifndef COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_EXTERNAL_DELEGATE_H_
6 #define COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_EXTERNAL_DELEGATE_H_ 6 #define COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_EXTERNAL_DELEGATE_H_
7 7
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/compiler_specific.h" 10 #include "base/compiler_specific.h"
(...skipping 124 matching lines...) Expand 10 before | Expand all | Expand 10 after
135 bool has_suggestion_; 135 bool has_suggestion_;
136 136
137 // Have we already shown Autofill suggestions for the field the user is 137 // Have we already shown Autofill suggestions for the field the user is
138 // currently editing? Used to keep track of state for metrics logging. 138 // currently editing? Used to keep track of state for metrics logging.
139 bool has_shown_popup_for_current_edit_; 139 bool has_shown_popup_for_current_edit_;
140 140
141 // The current data list values. 141 // The current data list values.
142 std::vector<base::string16> data_list_values_; 142 std::vector<base::string16> data_list_values_;
143 std::vector<base::string16> data_list_labels_; 143 std::vector<base::string16> data_list_labels_;
144 144
145 #if defined(OS_MACOSX)
146 // If this property is set, then the autofill popup should be immediately
147 // redisplayed when the text field loses focus.
148 bool redisplay_autofill_;
Ilya Sherman 2014/05/22 15:13:59 nit: Perhaps "redisplay_popop_on_focus_lost_" or s
erikchen 2014/05/22 20:40:59 I've changed the property name to your suggestion.
149 #endif
150
145 base::WeakPtrFactory<AutofillExternalDelegate> weak_ptr_factory_; 151 base::WeakPtrFactory<AutofillExternalDelegate> weak_ptr_factory_;
146 152
147 DISALLOW_COPY_AND_ASSIGN(AutofillExternalDelegate); 153 DISALLOW_COPY_AND_ASSIGN(AutofillExternalDelegate);
148 }; 154 };
149 155
150 } // namespace autofill 156 } // namespace autofill
151 157
152 #endif // COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_EXTERNAL_DELEGATE_H_ 158 #endif // COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_EXTERNAL_DELEGATE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698