components/autofill/core/browser/personal_data_manager.cc - Issue 286243002: Mac: Autofill should not immediately request access to address book.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/personal_data_manager.cc

Issue 286243002: Mac: Autofill should not immediately request access to address book. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: More cleanup. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/autofill/core/browser/autofill_manager.cc ('K') | « components/autofill/core/browser/personal_data_manager.h ('k') | components/autofill/core/browser/personal_data_manager_mac.mm » ('j') | components/autofill/core/browser/personal_data_manager_mac.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/personal_data_manager.cc

diff --git a/components/autofill/core/browser/personal_data_manager.cc b/components/autofill/core/browser/personal_data_manager.cc

index 1d4173e592564b7f0d24937d8cbc9d994ddbea25..7dd6d121513ca8e2f72c074ee359d1ca158d84e7 100644

--- a/components/autofill/core/browser/personal_data_manager.cc

+++ b/components/autofill/core/browser/personal_data_manager.cc

@@ -914,6 +914,14 @@ void PersonalDataManager::LoadProfiles() {

#if defined(OS_IOS) || (!defined(OS_MACOSX) && !defined(OS_ANDROID))

void PersonalDataManager::LoadAuxiliaryProfiles() const {

}

+bool PersonalDataManager::HasAccessMacContacts() {

+ return false;

+void PersonalDataManager::AccessMacContacts() {

Ilya Sherman 2014/05/16 22:54:02 Either these methods should not have "Mac" in the

erikchen 2014/05/19 20:58:32 I've removed these methods from personal_data_mana

#endif

void PersonalDataManager::LoadCreditCards() {