Mac: Autofill should not immediately request access to address book.

components/autofill/core/browser/personal_data_manager.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/core/browser/personal_data_manager.h"
 
 #include <algorithm>
 #include <functional>
 #include <iterator>
 
@@ skipping 896 matching lines @@
   CancelPendingQuery(&pending_profiles_query_);
 
   pending_profiles_query_ = database_->GetAutofillProfiles(this);
 }
 
 // Win, Linux, and iOS implementations do nothing. Mac and Android
 // implementations fill in the contents of |auxiliary_profiles_|.
 #if defined(OS_IOS) || (!defined(OS_MACOSX) && !defined(OS_ANDROID))
 void PersonalDataManager::LoadAuxiliaryProfiles() const {
 }
+
+bool PersonalDataManager::HasAccessMacContacts() {
+  return false;
+}
+
+void PersonalDataManager::AccessMacContacts() {

[Ilya Sherman, 2014/05/16 22:54:02]

Either these methods should not have "Mac" in the name at all, or they should
only be defined on Mac OS X.

[erikchen, 2014/05/19 20:58:32]

I've removed these methods from personal_data_manager.cc

+}
+
 #endif
 
 void PersonalDataManager::LoadCreditCards() {
   if (!database_.get()) {
     NOTREACHED();
     return;
   }
 
   CancelPendingQuery(&pending_creditcards_query_);
 
@@ skipping 145 matching lines @@
 
   return std::string();
 }
 
 void PersonalDataManager::EnabledPrefChanged() {
   default_country_code_.clear();
   NotifyPersonalDataChanged();
 }
 
 }  // namespace autofill