Mac: Autofill should not immediately request access to address book.

components/autofill/core/browser/autofill_manager.h

Index: components/autofill/core/browser/autofill_manager.h
diff --git a/components/autofill/core/browser/autofill_manager.h b/components/autofill/core/browser/autofill_manager.h
index 856be0e989ba737b169f5ee3db628941cfe3cd1a..098b184e3bdf55d8b3c4ceb333cd9bd445d306e0 100644
--- a/components/autofill/core/browser/autofill_manager.h
+++ b/components/autofill/core/browser/autofill_manager.h
@@ -83,6 +83,14 @@ class AutofillManager : public AutofillDownloadManager::Observer {
   void SetExternalDelegate(AutofillExternalDelegate* delegate);
 
   void ShowAutofillSettings();
+  // Whether an autofill cell should be shown to prompt the user to give
+  // Chromium access to the user's address book, given a particular form field
+  // inside of a form.
+  bool ShouldShowAccessMacContacts(const FormData& data,
+                                   const FormFieldData& fieldData);

[Ilya Sherman, 2014/05/16 22:54:02]

This method is too closely tied to the UI.  Instead, this can be split into two
parts:
  (1) A method "bool HasQueriedForAccessToMacContacts()" (or, you know, a
shorter and better method name :P) that returns whether or not we've ever shown
the permission prompt to the user.
  (2) If the popup has no Autofill suggestions for a field, and
HasQueriedForAccessToMacContacts() returns false, show the extra row.

[erikchen, 2014/05/19 20:58:32]

I've done as you've suggested and split the logic into two methods: 
bool HasPromptedForAccessToAddressBook
bool FieldSupportsAddressBookAutofill

+  // Invokes the system prompt to give Chromium access to the user's address
+  // book. This method is blocking.
+  void AccessMacContacts();

[Ilya Sherman, 2014/05/16 22:54:02]

These methods should only be available on Mac OS X.

[erikchen, 2014/05/19 20:58:32]

I've added #if defined(OS_MACOSX) to all the mac specific methods in this CL.

 
   // Called from our external delegate so they cannot be private.
   virtual void FillOrPreviewForm(AutofillDriver::RendererFormDataAction action,