Mac: Autofill should not immediately request access to address book.

components/autofill/core/browser/autofill_manager.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_MANAGER_H_
 #define COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_MANAGER_H_
 
 #include <list>
 #include <map>
 #include <string>
@@ skipping 65 matching lines @@
   AutofillManager(AutofillDriver* driver,
                   autofill::AutofillManagerDelegate* delegate,
                   const std::string& app_locale,
                   AutofillDownloadManagerState enable_download_manager);
   virtual ~AutofillManager();
 
   // Sets an external delegate.
   void SetExternalDelegate(AutofillExternalDelegate* delegate);
 
   void ShowAutofillSettings();
+  // Whether an autofill cell should be shown to prompt the user to give
+  // Chromium access to the user's address book, given a particular form field
+  // inside of a form.
+  bool ShouldShowAccessMacContacts(const FormData& data,
+                                   const FormFieldData& fieldData);

[Ilya Sherman, 2014/05/16 22:54:02]

This method is too closely tied to the UI.  Instead, this can be split into two
parts:
  (1) A method "bool HasQueriedForAccessToMacContacts()" (or, you know, a
shorter and better method name :P) that returns whether or not we've ever shown
the permission prompt to the user.
  (2) If the popup has no Autofill suggestions for a field, and
HasQueriedForAccessToMacContacts() returns false, show the extra row.

[erikchen, 2014/05/19 20:58:32]

I've done as you've suggested and split the logic into two methods: 
bool HasPromptedForAccessToAddressBook
bool FieldSupportsAddressBookAutofill

+  // Invokes the system prompt to give Chromium access to the user's address
+  // book. This method is blocking.
+  void AccessMacContacts();

[Ilya Sherman, 2014/05/16 22:54:02]

These methods should only be available on Mac OS X.

[erikchen, 2014/05/19 20:58:32]

I've added #if defined(OS_MACOSX) to all the mac specific methods in this CL.

 
   // Called from our external delegate so they cannot be private.
   virtual void FillOrPreviewForm(AutofillDriver::RendererFormDataAction action,
                                  int query_id,
                                  const FormData& form,
                                  const FormFieldData& field,
                                  int unique_id);
   void DidShowSuggestions(bool is_new_popup);
   void OnDidFillAutofillFormData(const base::TimeTicks& timestamp);
   void OnDidPreviewAutofillFormData();
@@ skipping 261 matching lines @@
                            UserHappinessFormLoadAndSubmission);
   FRIEND_TEST_ALL_PREFIXES(AutofillMetricsTest, UserHappinessFormInteraction);
   FRIEND_TEST_ALL_PREFIXES(AutofillManagerTest,
                            FormSubmittedAutocompleteEnabled);
   DISALLOW_COPY_AND_ASSIGN(AutofillManager);
 };
 
 }  // namespace autofill
 
 #endif  // COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_MANAGER_H_