Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Issue 2862413003: Convert ScriptProcessorNode tests to us new Audit (Closed)

Created:
3 years, 7 months ago by Raymond Toy
Modified:
3 years, 7 months ago
Reviewers:
hongchan
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert ScriptProcessorNode tests to us new Audit Manually converted ScriptProcessNode tests to use new Audit. BUG=704967 TEST= ScriptProcessor/scriptprocessor-offlineaudiocontext.html ScriptProcessor/scriptprocessornode-0-output-channels.html Review-Url: https://codereview.chromium.org/2862413003 Cr-Commit-Position: refs/heads/master@{#470174} Committed: https://chromium.googlesource.com/chromium/src/+/708cd970d80e783f41036e8ac700b5f69e120407

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -91 lines) Patch
M third_party/WebKit/LayoutTests/webaudio/ScriptProcessor/scriptprocessor-offlineaudiocontext.html View 1 chunk +69 lines, -71 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/ScriptProcessor/scriptprocessornode-0-output-channels.html View 2 chunks +26 lines, -20 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Raymond Toy
PTAL
3 years, 7 months ago (2017-05-08 15:24:42 UTC) #2
hongchan
lgtm
3 years, 7 months ago (2017-05-08 20:40:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2862413003/1
3 years, 7 months ago (2017-05-08 20:56:26 UTC) #5
commit-bot: I haz the power
3 years, 7 months ago (2017-05-09 03:56:38 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/708cd970d80e783f41036e8ac700...

Powered by Google App Engine
This is Rietveld 408576698