Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Issue 2862413002: (Tiny) Make some execution_phase.cc includes windows only (Closed)

Created:
3 years, 7 months ago by manzagop (departed)
Modified:
3 years, 7 months ago
Reviewers:
Steven Holte
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Make some execution_phase.cc includes windows only This is a follow up to https://codereview.chromium.org/2860863003/. Surprisingly the build isn't broken. BUG=718437 Review-Url: https://codereview.chromium.org/2862413002 Cr-Commit-Position: refs/heads/master@{#469969} Committed: https://chromium.googlesource.com/chromium/src/+/a50215b18581e0623f549a2aaf8586bdfe755db9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M components/metrics/execution_phase.cc View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
manzagop (departed)
Hi Steven, This is a tiny follow up. Please have a look! Thanks! Pierre
3 years, 7 months ago (2017-05-05 21:30:43 UTC) #4
Steven Holte
lgtm
3 years, 7 months ago (2017-05-05 21:41:58 UTC) #5
manzagop (departed)
Thanks!
3 years, 7 months ago (2017-05-05 21:53:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2862413002/1
3 years, 7 months ago (2017-05-08 00:47:22 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/437846)
3 years, 7 months ago (2017-05-08 01:32:47 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2862413002/1
3 years, 7 months ago (2017-05-08 12:07:32 UTC) #14
commit-bot: I haz the power
3 years, 7 months ago (2017-05-08 13:01:32 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a50215b18581e0623f549a2aaf85...

Powered by Google App Engine
This is Rietveld 408576698