Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(787)

Issue 2862383002: Clarify presentation of the target in retaining paths. (Closed)

Created:
3 years, 7 months ago by rmacnak
Modified:
3 years, 7 months ago
Reviewers:
aam, mfairhurst
CC:
reviews_dartlang.org, turnidge, Cutch, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Clarify presentation of the target in retaining paths. Update styles etc to fix missing italics. R=aam@google.com Committed: https://github.com/dart-lang/sdk/commit/51ce2ba5e8bada690b3087f4cba4dadac03f5f23

Patch Set 1 #

Total comments: 2

Patch Set 2 : review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -44 lines) Patch
M runtime/observatory/lib/src/elements/code_view.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/css/shared.css View 10 chunks +70 lines, -19 lines 0 comments Download
M runtime/observatory/lib/src/elements/error_view.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/inbound_references.dart View 1 1 chunk +3 lines, -4 lines 0 comments Download
M runtime/observatory/lib/src/elements/instance_ref.dart View 1 4 chunks +14 lines, -9 lines 0 comments Download
M runtime/observatory/lib/src/elements/objectpool_view.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/retaining_path.dart View 2 chunks +24 lines, -8 lines 0 comments Download
M runtime/observatory/lib/src/elements/timeline_page.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/unknown_ref.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
rmacnak
3 years, 7 months ago (2017-05-05 20:23:54 UTC) #2
rmacnak
3 years, 7 months ago (2017-05-09 17:18:47 UTC) #4
aam
LGTM https://codereview.chromium.org/2862383002/diff/1/runtime/observatory/lib/src/elements/instance_ref.dart File runtime/observatory/lib/src/elements/instance_ref.dart (right): https://codereview.chromium.org/2862383002/diff/1/runtime/observatory/lib/src/elements/instance_ref.dart#newcode140 runtime/observatory/lib/src/elements/instance_ref.dart:140: ..text = "Closure", Are double quotes (vs single ...
3 years, 7 months ago (2017-05-09 17:44:19 UTC) #5
rmacnak
https://codereview.chromium.org/2862383002/diff/1/runtime/observatory/lib/src/elements/instance_ref.dart File runtime/observatory/lib/src/elements/instance_ref.dart (right): https://codereview.chromium.org/2862383002/diff/1/runtime/observatory/lib/src/elements/instance_ref.dart#newcode140 runtime/observatory/lib/src/elements/instance_ref.dart:140: ..text = "Closure", On 2017/05/09 17:44:19, aam2 wrote: > ...
3 years, 7 months ago (2017-05-09 17:47:54 UTC) #6
rmacnak
3 years, 7 months ago (2017-05-09 20:37:38 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
51ce2ba5e8bada690b3087f4cba4dadac03f5f23 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698