Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1193)

Unified Diff: runtime/observatory/lib/src/elements/inbound_references.dart

Issue 2862383002: Clarify presentation of the target in retaining paths. (Closed)
Patch Set: review Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/lib/src/elements/inbound_references.dart
diff --git a/runtime/observatory/lib/src/elements/inbound_references.dart b/runtime/observatory/lib/src/elements/inbound_references.dart
index 8e68a00a27728b2761aa0e9caa48a3dec73d373f..8aab33a8e1b7adef76f916fcf3ff2ecc80458ab4 100644
--- a/runtime/observatory/lib/src/elements/inbound_references.dart
+++ b/runtime/observatory/lib/src/elements/inbound_references.dart
@@ -93,21 +93,20 @@ class InboundReferencesElement extends HtmlElement implements Renderable {
if (reference.parentField != null) {
content.addAll([
- new SpanElement()..text = 'from ',
+ new SpanElement()..text = 'referenced by ',
anyRef(_isolate, reference.parentField, _instances, queue: _r.queue),
new SpanElement()..text = ' of '
]);
} else if (reference.parentListIndex != null) {
content.add(new SpanElement()
- ..text = 'from [ ${reference.parentListIndex} ] of ');
+ ..text = 'referenced by [ ${reference.parentListIndex} ] of ');
} else if (reference.parentWordOffset != null) {
content.add(new SpanElement()
- ..text = 'from word [ ${reference.parentWordOffset} ] of ');
+ ..text = 'referenced by offset ${reference.parentWordOffset} of ');
}
content.addAll([
anyRef(_isolate, reference.source, _instances, queue: _r.queue),
- new SpanElement()..text = ' referenced by ',
new InboundReferencesElement(
_isolate, reference.source, _references, _instances,
queue: _r.queue)
« no previous file with comments | « runtime/observatory/lib/src/elements/error_view.dart ('k') | runtime/observatory/lib/src/elements/instance_ref.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698