chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpUploadService.java - Issue 2862353003: [Crash Reporting] Fix a race between uploading and appending logcat data.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpUploadService.java

Issue 2862353003: [Crash Reporting] Fix a race between uploading and appending logcat data. (Closed)

Patch Set: Rebase Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/crash/ChromeMinidumpUploaderDelegate.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/init/ProcessInitializationHandler.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpUploadService.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpUploadService.java b/chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpUploadService.java

index 7fcc2add43049f0973443225ebb51662d44bed4f..ddef71eb90dd3f39f78c87d4c5f68aa8de058347 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpUploadService.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpUploadService.java

@@ -320,7 +320,7 @@ public class MinidumpUploadService extends IntentService {

assert !shouldUseJobSchedulerForUploads();

CrashFileManager fileManager =

new CrashFileManager(ContextUtils.getApplicationContext().getCacheDir());

- File[] minidumps = fileManager.getAllMinidumpFiles(MAX_TRIES_ALLOWED);

+ File[] minidumps = fileManager.getMinidumpsReadyForUpload(MAX_TRIES_ALLOWED);

Log.i(TAG, "Attempting to upload accumulated crash dumps.");

for (File minidump : minidumps) {

tryUploadCrashDump(minidump);