Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/crash/ChromeMinidumpUploaderDelegate.java

Issue 2862353003: [Crash Reporting] Fix a race between uploading and appending logcat data. (Closed)
Patch Set: Rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/crash/ChromeMinidumpUploaderDelegate.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/crash/ChromeMinidumpUploaderDelegate.java b/chrome/android/java/src/org/chromium/chrome/browser/crash/ChromeMinidumpUploaderDelegate.java
index 8e0ec0a22b98ca361b1764add45c9a960b3e84e3..103ea085ed38aad778891f5e4faeb1ea538aac71 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/crash/ChromeMinidumpUploaderDelegate.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/crash/ChromeMinidumpUploaderDelegate.java
@@ -10,6 +10,7 @@ import android.os.Build;
import android.os.PersistableBundle;
import org.chromium.chrome.browser.preferences.privacy.PrivacyPreferencesManager;
+import org.chromium.components.minidump_uploader.CrashFileManager;
import org.chromium.components.minidump_uploader.MinidumpUploaderDelegate;
import org.chromium.components.minidump_uploader.util.CrashReportingPermissionManager;
import org.chromium.components.minidump_uploader.util.NetworkPermissionUtil;
@@ -98,4 +99,10 @@ public class ChromeMinidumpUploaderDelegate implements MinidumpUploaderDelegate
public void recordUploadFailure(File minidump) {
MinidumpUploadService.incrementCrashFailureUploadCount(minidump.getAbsolutePath());
}
+
+ @Override
+ public void migrateMinidumpFilenamesIfNeeded(CrashFileManager crashFileManager) {
+ // Minidump filenames are migrated as part of attaching logcats within the
+ // ProcessInitializationHandler, and hence there is no need to migrate them here.
+ }
}

Powered by Google App Engine
This is Rietveld 408576698