Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2862313004:
Fix URL text drags. (Closed)
|
Created:
3 years, 7 months ago by Avi (use Gerrit) Modified:
3 years, 7 months ago CC:
chromium-reviews, dcheng, mac-reviews_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionFix URL text drags.
Don’t allow the system to wrap them, as that defeats the fade.
BUG=719104
TEST=as in bug
Review-Url: https://codereview.chromium.org/2862313004
Cr-Commit-Position: refs/heads/master@{#470037}
Committed: https://chromium.googlesource.com/chromium/src/+/740693b4ba32b11aed1fabcdd0cc92abe36430d1
Patch Set 1 #
Messages
Total messages: 23 (13 generated)
The CQ bit was checked by avi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
avi@chromium.org changed reviewers: + lgrey@chromium.org
lgtm (But note that I'm not yet a committer)
avi@chromium.org changed reviewers: + sdy@chromium.org
Sidney, can you take a look then?
lgtm
The CQ bit was checked by avi@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
The CQ bit was checked by avi@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
The CQ bit was checked by avi@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1494264519505770, "parent_rev":
"e0f867b3e07d76f29db264c2bfa1c4d67dbc8e59", "commit_rev":
"740693b4ba32b11aed1fabcdd0cc92abe36430d1"}
Message was sent while issue was closed.
Description was changed from ========== Fix URL text drags. Don’t allow the system to wrap them, as that defeats the fade. BUG=719104 TEST=as in bug ========== to ========== Fix URL text drags. Don’t allow the system to wrap them, as that defeats the fade. BUG=719104 TEST=as in bug Review-Url: https://codereview.chromium.org/2862313004 Cr-Commit-Position: refs/heads/master@{#470037} Committed: https://chromium.googlesource.com/chromium/src/+/740693b4ba32b11aed1fabcdd0cc... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/740693b4ba32b11aed1fabcdd0cc... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
