Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 2862143004: Remove SchedulerWorkerPoolImpl::ReEnqueueSequenceCallback. (Closed)

Created:
3 years, 7 months ago by fdoray
Modified:
3 years, 7 months ago
Reviewers:
robliao, gab
CC:
chromium-reviews, gab+watch_chromium.org, robliao+watch_chromium.org, fdoray+watch_chromium.org, danakj+watch_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove SchedulerWorkerPoolImpl::ReEnqueueSequenceCallback. This was useful when we thought that sequences could contain tasks with different traits and be enqueued in different priority queues during their lifetime. This is no longer a supported use case. BUG=553459 Review-Url: https://codereview.chromium.org/2862143004 Cr-Commit-Position: refs/heads/master@{#470034} Committed: https://chromium.googlesource.com/chromium/src/+/be1c345dc5a61438d6aeb57544689cfe22598ffc

Patch Set 1 #

Total comments: 2

Patch Set 2 : CR-robliao-remove-includes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -109 lines) Patch
M base/task_scheduler/scheduler_worker_pool.h View 2 chunks +0 lines, -10 lines 0 comments Download
M base/task_scheduler/scheduler_worker_pool_impl.h View 1 4 chunks +2 lines, -12 lines 0 comments Download
M base/task_scheduler/scheduler_worker_pool_impl.cc View 7 chunks +9 lines, -34 lines 0 comments Download
M base/task_scheduler/scheduler_worker_pool_impl_unittest.cc View 4 chunks +2 lines, -23 lines 0 comments Download
M base/task_scheduler/task_scheduler_impl.h View 1 2 chunks +0 lines, -5 lines 0 comments Download
M base/task_scheduler/task_scheduler_impl.cc View 1 3 chunks +3 lines, -25 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
fdoray
PTAL
3 years, 7 months ago (2017-05-05 19:28:46 UTC) #2
robliao
lgtm https://codereview.chromium.org/2862143004/diff/1/base/task_scheduler/task_scheduler_impl.h File base/task_scheduler/task_scheduler_impl.h (right): https://codereview.chromium.org/2862143004/diff/1/base/task_scheduler/task_scheduler_impl.h#newcode21 base/task_scheduler/task_scheduler_impl.h:21: #include "base/task_scheduler/sequence.h" This can probably be moved into ...
3 years, 7 months ago (2017-05-05 21:23:39 UTC) #3
fdoray
https://codereview.chromium.org/2862143004/diff/1/base/task_scheduler/task_scheduler_impl.h File base/task_scheduler/task_scheduler_impl.h (right): https://codereview.chromium.org/2862143004/diff/1/base/task_scheduler/task_scheduler_impl.h#newcode21 base/task_scheduler/task_scheduler_impl.h:21: #include "base/task_scheduler/sequence.h" On 2017/05/05 21:23:39, robliao wrote: > This ...
3 years, 7 months ago (2017-05-08 14:54:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2862143004/20001
3 years, 7 months ago (2017-05-08 14:56:51 UTC) #10
gab
lgtm
3 years, 7 months ago (2017-05-08 15:55:51 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-05-08 17:31:16 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/be1c345dc5a61438d6aeb5754468...

Powered by Google App Engine
This is Rietveld 408576698