MD Settings: Certificates: Hide 'import and bind' in guest mode

MD Settings: Certificates: Hide 'import and bind' in guest mode

BUG=717204
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2862123003
Cr-Commit-Position: refs/heads/master@{#470089}
Committed: https://chromium.googlesource.com/chromium/src/+/42903557b72caced422c866ff2e5052e2ec3affa

[stevenjb, 2017-05-04 22:59:02]

Description was changed from

==========
MD Settings: Certificates: Hide 'import and bind' in guest mode

BUG=717204
==========

to

==========
MD Settings: Certificates: Hide 'import and bind' in guest mode

BUG=717204
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[stevenjb, 2017-05-04 23:10:47]

stevenjb@chromium.org changed reviewers:
+ dpapad@chromium.org

[dpapad, 2017-05-04 23:35:40]

LGTM

https://codereview.chromium.org/2862123003/diff/1/chrome/browser/resources/se...
File
chrome/browser/resources/settings/certificate_manager_page/certificate_list.html
(right):

https://codereview.chromium.org/2862123003/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/certificate_manager_page/certificate_list.html:25:
hidden="[[!canImportAndBind_(certificateType, isGuest_)]]">
The bug report is calling from graying out the button (meaning disabling),
instead of hiding. I don't mind either way, but let's just make sure that hiding
is just as good as disabling (maybe ask @tbuckley?).

https://codereview.chromium.org/2862123003/diff/1/chrome/browser/resources/se...
File
chrome/browser/resources/settings/certificate_manager_page/certificate_list.js
(right):

https://codereview.chromium.org/2862123003/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/certificate_manager_page/certificate_list.js:71:
return !this.isGuest_ && this.certificateType == CertificateType.PERSONAL;
Optional: If you think this functionality is important, I suggest adding a test
at the corresponding test suite, at 

https://cs.chromium.org/chromium/src/chrome/test/data/webui/settings/certific....

[stevenjb, 2017-05-08 16:44:44]

https://codereview.chromium.org/2862123003/diff/1/chrome/browser/resources/se...
File
chrome/browser/resources/settings/certificate_manager_page/certificate_list.html
(right):

https://codereview.chromium.org/2862123003/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/certificate_manager_page/certificate_list.html:25:
hidden="[[!canImportAndBind_(certificateType, isGuest_)]]">
On 2017/05/04 23:35:40, dpapad wrote:
> The bug report is calling from graying out the button (meaning disabling),
> instead of hiding. I don't mind either way, but let's just make sure that
hiding
> is just as good as disabling (maybe ask @tbuckley?).

Hiding as per comment in crbug.com/717204

https://codereview.chromium.org/2862123003/diff/1/chrome/browser/resources/se...
File
chrome/browser/resources/settings/certificate_manager_page/certificate_list.js
(right):

https://codereview.chromium.org/2862123003/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/certificate_manager_page/certificate_list.js:71:
return !this.isGuest_ && this.certificateType == CertificateType.PERSONAL;
On 2017/05/04 23:35:40, dpapad wrote:
> Optional: If you think this functionality is important, I suggest adding a
test
> at the corresponding test suite, at 
> 
>
https://cs.chromium.org/chromium/src/chrome/test/data/webui/settings/certific....

We don't currently have any "guest mode" tests that I am aware of, but we
probably should. I don't think we should necessarily do this in individual page
tests (but maybe we should). Filed crbug.com/719562 to track this.

[stevenjb, 2017-05-08 16:44:48]

The CQ bit was checked by stevenjb@chromium.org

[commit-bot: I haz the power, 2017-05-08 16:45:12]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-08 17:42:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-08 17:42:02]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[stevenjb, 2017-05-08 18:49:29]

The CQ bit was checked by stevenjb@chromium.org

[commit-bot: I haz the power, 2017-05-08 18:50:36]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-08 19:56:11]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1494269369997320, "parent_rev":
"afa872d246526609a0ebbd0ef0000387d76279a9", "commit_rev":
"42903557b72caced422c866ff2e5052e2ec3affa"}

[commit-bot: I haz the power, 2017-05-08 19:56:20]

Description was changed from

==========
MD Settings: Certificates: Hide 'import and bind' in guest mode

BUG=717204
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Certificates: Hide 'import and bind' in guest mode

BUG=717204
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2862123003
Cr-Commit-Position: refs/heads/master@{#470089}
Committed:
https://chromium.googlesource.com/chromium/src/+/42903557b72caced422c866ff2e5...
==========

[commit-bot: I haz the power, 2017-05-08 19:56:21]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/42903557b72caced422c866ff2e5...