Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 2862023004: [MD settings] use All as generic test name (Closed)

Created:
3 years, 7 months ago by dschuyler
Modified:
3 years, 7 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] use All as generic test name This CL changes the various secondary test names to 'All' where there is no selection of tests made in the category. In categories where sub-tests can be run separately, the secondary names remain unique. (code health) BUG=None Review-Url: https://codereview.chromium.org/2862023004 Cr-Commit-Position: refs/heads/master@{#469729} Committed: https://chromium.googlesource.com/chromium/src/+/84d4dbfe4224fd1f9b1eee74e748135f98e961a7

Patch Set 1 #

Patch Set 2 : merge with master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -46 lines) Patch
M chrome/test/data/webui/settings/cr_settings_browsertest.js View 34 chunks +40 lines, -46 lines 0 comments Download

Messages

Total messages: 18 (13 generated)
dschuyler
WDYT? (A follow-up for Issue 2862463002).
3 years, 7 months ago (2017-05-04 23:18:55 UTC) #4
Dan Beam
lgtm
3 years, 7 months ago (2017-05-04 23:30:09 UTC) #5
dschuyler
Merge / reset upstream with master - no changes from patch 1.
3 years, 7 months ago (2017-05-05 01:12:02 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2862023004/20001
3 years, 7 months ago (2017-05-05 18:15:59 UTC) #15
commit-bot: I haz the power
3 years, 7 months ago (2017-05-05 18:26:57 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/84d4dbfe4224fd1f9b1eee74e748...

Powered by Google App Engine
This is Rietveld 408576698