Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 2862013002: [selectors4] Remove :focus-within test that is now duplicated (Closed)

Created:
3 years, 7 months ago by Manuel Rego
Modified:
3 years, 7 months ago
Reviewers:
rune
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[selectors4] Remove :focus-within test that is now duplicated This patch removes the following test: fast/selectors/focus-within-display-none.html The test was upstreamed into the WPT repository and it's imported as: external/wpt/css/selectors4/focus-within-display-none-001.html The new test includes the old checks and some more, so we don't need our own test anymore. BUG=617371 Review-Url: https://codereview.chromium.org/2862013002 Cr-Commit-Position: refs/heads/master@{#469610} Committed: https://chromium.googlesource.com/chromium/src/+/29a9ed148cf67932faa0868735ab9a405ad81c97

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -28 lines) Patch
M third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/fast/selectors/focus-within-display-none.html View 1 chunk +0 lines, -27 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Manuel Rego
3 years, 7 months ago (2017-05-04 15:22:08 UTC) #3
rune
lgtm
3 years, 7 months ago (2017-05-04 17:22:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2862013002/1
3 years, 7 months ago (2017-05-05 07:02:20 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2017-05-05 07:13:19 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/29a9ed148cf67932faa0868735ab...

Powered by Google App Engine
This is Rietveld 408576698