Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(834)

Issue 2862003004: Mac: Fix infobar anchor under Harmony. (Closed)

Created:
3 years, 7 months ago by tapted
Modified:
3 years, 7 months ago
Reviewers:
Elly Fong-Jones
CC:
chromium-reviews, mac-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Mac: Fix infobar anchor under Harmony. For the most part, this is just a rename of `pageInfoBubblePointY` to `infoBarAnchorPointY` since it's only used for InfoBars, and never used for the page info bubble. page_info_bubble_controller.mm and other things anchoring off the location icon just use LocationBarViewMac::GetPageInfoBubblePoint() directly. Adds LocationBarViewMac::GetInfoBarAnchorPoint() since InfoBars will still have arrows under Harmony, while bubbles will not. BUG=689906 Review-Url: https://codereview.chromium.org/2862003004 Cr-Commit-Position: refs/heads/master@{#470202} Committed: https://chromium.googlesource.com/chromium/src/+/3248f4867e7ac406e88ac458ae1d34c168506636

Patch Set 1 #

Total comments: 2

Patch Set 2 : s/. I/ i/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -32 lines) Patch
M chrome/browser/ui/cocoa/browser_window_controller_private.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller_private.mm View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_layout.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_layout.mm View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_layout_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/location_bar/autocomplete_text_field.h View 1 1 chunk +5 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/location_bar/autocomplete_text_field.mm View 1 chunk +18 lines, -16 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h View 1 chunk +5 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
tapted
Hi Elly, please take a look
3 years, 7 months ago (2017-05-05 06:09:19 UTC) #5
Elly Fong-Jones
lgtm :) https://codereview.chromium.org/2862003004/diff/1/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field.h File chrome/browser/ui/cocoa/location_bar/autocomplete_text_field.h (right): https://codereview.chromium.org/2862003004/diff/1/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field.h#newcode172 chrome/browser/ui/cocoa/location_bar/autocomplete_text_field.h:172: // Returns the anchor point for arrows ...
3 years, 7 months ago (2017-05-08 15:49:55 UTC) #8
tapted
Thanks Elly! https://codereview.chromium.org/2862003004/diff/1/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field.h File chrome/browser/ui/cocoa/location_bar/autocomplete_text_field.h (right): https://codereview.chromium.org/2862003004/diff/1/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field.h#newcode172 chrome/browser/ui/cocoa/location_bar/autocomplete_text_field.h:172: // Returns the anchor point for arrows ...
3 years, 7 months ago (2017-05-09 03:24:28 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2862003004/20001
3 years, 7 months ago (2017-05-09 03:26:24 UTC) #12
commit-bot: I haz the power
3 years, 7 months ago (2017-05-09 04:25:21 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/3248f4867e7ac406e88ac458ae1d...

Powered by Google App Engine
This is Rietveld 408576698