Mac: Fix infobar anchor under Harmony.

Mac: Fix infobar anchor under Harmony.

For the most part, this is just a rename of `pageInfoBubblePointY` to
`infoBarAnchorPointY` since it's only used for InfoBars, and never used
for the page info bubble.

page_info_bubble_controller.mm and other things anchoring off the
location icon just use LocationBarViewMac::GetPageInfoBubblePoint()
directly.

Adds LocationBarViewMac::GetInfoBarAnchorPoint() since InfoBars will
still have arrows under Harmony, while bubbles will not.

BUG=689906
Review-Url: https://codereview.chromium.org/2862003004
Cr-Commit-Position: refs/heads/master@{#470202}
Committed: https://chromium.googlesource.com/chromium/src/+/3248f4867e7ac406e88ac458ae1d34c168506636

[tapted, 2017-05-05 05:58:48]

The CQ bit was checked by tapted@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-05 05:58:58]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tapted, 2017-05-05 06:05:35]

Description was changed from

==========
Mac: Fix infobar anchor under Harmony.

BUG=689906
==========

to

==========
Mac: Fix infobar anchor under Harmony.

For the most part, this is just a rename of `pageInfoBubblePointY` to
`infoBarAnchorPointY` since it's only used for InfoBars, and never used
for the page info bubble.

page_info_bubble_controller.mm and other things anchoring off the
location icon just use LocationBarViewMac::GetPageInfoBubblePoint()
directly.

Adds LocationBarViewMac::GetInfoBarAnchorPoint() since InfoBars will
still have arrows under Harmony, while bubbles will not.

BUG=689906
==========

[tapted, 2017-05-05 06:05:35]

tapted@chromium.org changed reviewers:
+ ellyjones@chromium.org

[tapted, 2017-05-05 06:09:19]

Hi Elly, please take a look

[commit-bot: I haz the power, 2017-05-05 06:23:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-05 06:23:34]

Dry run: This issue passed the CQ dry run.

[Elly Fong-Jones, 2017-05-08 15:49:55]

lgtm :)

https://codereview.chromium.org/2862003004/diff/1/chrome/browser/ui/cocoa/loc...
File chrome/browser/ui/cocoa/location_bar/autocomplete_text_field.h (right):

https://codereview.chromium.org/2862003004/diff/1/chrome/browser/ui/cocoa/loc...
chrome/browser/ui/cocoa/location_bar/autocomplete_text_field.h:172: // Returns
the anchor point for arrows pointing to |decoration|. In window
s/. I/ i/ to make this all one sentence

[tapted, 2017-05-09 03:24:28]

Thanks Elly!

https://codereview.chromium.org/2862003004/diff/1/chrome/browser/ui/cocoa/loc...
File chrome/browser/ui/cocoa/location_bar/autocomplete_text_field.h (right):

https://codereview.chromium.org/2862003004/diff/1/chrome/browser/ui/cocoa/loc...
chrome/browser/ui/cocoa/location_bar/autocomplete_text_field.h:172: // Returns
the anchor point for arrows pointing to |decoration|. In window
On 2017/05/08 15:49:55, Elly Fong-Jones wrote:
> s/. I/ i/ to make this all one sentence

Done.

[tapted, 2017-05-09 03:24:51]

The CQ bit was checked by tapted@chromium.org

[tapted, 2017-05-09 03:24:52]

The patchset sent to the CQ was uploaded after l-g-t-m from
ellyjones@chromium.org
Link to the patchset: https://codereview.chromium.org/2862003004/#ps20001
(title: "s/. I/ i/")

[commit-bot: I haz the power, 2017-05-09 03:26:24]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-09 04:25:10]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494300291829320,
"parent_rev": "a300d82623a027cfffdccbf472f7f7fb7c73912e", "commit_rev":
"3248f4867e7ac406e88ac458ae1d34c168506636"}

[commit-bot: I haz the power, 2017-05-09 04:25:18]

Description was changed from

==========
Mac: Fix infobar anchor under Harmony.

For the most part, this is just a rename of `pageInfoBubblePointY` to
`infoBarAnchorPointY` since it's only used for InfoBars, and never used
for the page info bubble.

page_info_bubble_controller.mm and other things anchoring off the
location icon just use LocationBarViewMac::GetPageInfoBubblePoint()
directly.

Adds LocationBarViewMac::GetInfoBarAnchorPoint() since InfoBars will
still have arrows under Harmony, while bubbles will not.

BUG=689906
==========

to

==========
Mac: Fix infobar anchor under Harmony.

For the most part, this is just a rename of `pageInfoBubblePointY` to
`infoBarAnchorPointY` since it's only used for InfoBars, and never used
for the page info bubble.

page_info_bubble_controller.mm and other things anchoring off the
location icon just use LocationBarViewMac::GetPageInfoBubblePoint()
directly.

Adds LocationBarViewMac::GetInfoBarAnchorPoint() since InfoBars will
still have arrows under Harmony, while bubbles will not.

BUG=689906

Review-Url: https://codereview.chromium.org/2862003004
Cr-Commit-Position: refs/heads/master@{#470202}
Committed:
https://chromium.googlesource.com/chromium/src/+/3248f4867e7ac406e88ac458ae1d...
==========

[commit-bot: I haz the power, 2017-05-09 04:25:21]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/3248f4867e7ac406e88ac458ae1d...