Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 2862003003: Reporting: Document browsing data remover + endpoint backoff (Closed)

Created:
3 years, 7 months ago by Julia Tuttle
Modified:
3 years, 7 months ago
Reviewers:
shivanisha
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reporting: Document browsing data remover + endpoint backoff The ReportingBrowsingDataRemover currently doesn't remove entries from the endpoint backoff map in the ReportingEndpointManager, because it's never persisted to disk. This CL adds comments in a couple places to note this, so someone implementing persistence for that knows to implement browsing data removal as well. BUG=704259, 676324 Review-Url: https://codereview.chromium.org/2862003003 Cr-Commit-Position: refs/heads/master@{#470336} Committed: https://chromium.googlesource.com/chromium/src/+/cf0772c92c9909b3ad0f107541a533c567bfda75

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M net/reporting/reporting_browsing_data_remover.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M net/reporting/reporting_endpoint_manager.h View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Julia Tuttle
PTAL, shivanisha.
3 years, 7 months ago (2017-05-04 17:12:17 UTC) #2
shivanisha
On 2017/05/04 at 17:12:17, juliatuttle wrote: > PTAL, shivanisha. lgtm
3 years, 7 months ago (2017-05-09 14:00:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2862003003/20001
3 years, 7 months ago (2017-05-09 14:32:38 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-09 15:05:59 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/cf0772c92c9909b3ad0f107541a5...

Powered by Google App Engine
This is Rietveld 408576698