Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2861963002: Fix bad refactoring in r467153. (Closed)

Created:
3 years, 7 months ago by Lei Zhang
Modified:
3 years, 7 months ago
Reviewers:
dpapad
CC:
arv+watch_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix bad refactoring in r467153. BUG=717765 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2861963002 Cr-Commit-Position: refs/heads/master@{#469406} Committed: https://chromium.googlesource.com/chromium/src/+/1a154cfde758d89dbdc84f33d4b03f808b6bdd74

Patch Set 1 : Fix bad refactoring in r467153. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/browser/resources/print_preview/search/cloud_destination_list.js View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (11 generated)
Lei Zhang
3 years, 7 months ago (2017-05-04 17:39:07 UTC) #9
dpapad
lgtm
3 years, 7 months ago (2017-05-04 17:48:45 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2861963002/40001
3 years, 7 months ago (2017-05-04 18:51:16 UTC) #12
commit-bot: I haz the power
3 years, 7 months ago (2017-05-04 18:57:23 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/1a154cfde758d89dbdc84f33d4b0...

Powered by Google App Engine
This is Rietveld 408576698